{{ message }}
Repository navigation
Expand file tree
/
Copy pathtest_asset_seeder.py
More file actions
404 lines (322 loc) · 14.9 KB
/
Copy pathtest_asset_seeder.py
File metadata and controls
404 lines (322 loc) · 14.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
import threading
from typing import Any
from unittest.mock import call, patch
import pytest
from app.assets.seeder import Progress, ScanPhase, _AssetSeeder, State
@pytest.fixture()
def seeder():
"""Fresh seeder instance for each test."""
return _AssetSeeder()
class TestEventSink:
def test_delivers_event_and_payload_to_sink(self, seeder):
received: list[tuple[str, dict[str, Any]]] = []
def record_event(event_type: str, data: dict[str, Any]) -> None:
received.append((event_type, data))
event_type = "assets.seed.started"
payload = {"roots": ["models"], "total": 1, "phase": "fast"}
seeder.set_event_sink(record_event)
seeder._emit_event(event_type, payload)
assert received == [(event_type, payload)]
def test_noop_when_no_sink_is_set(self, seeder):
assert seeder._emit_event("assets.seed.resumed", {}) is None
def test_swallows_raising_sink_exception(self, seeder):
def raise_from_sink(event_type: str, data: dict[str, Any]) -> None:
raise RuntimeError("boom")
seeder.set_event_sink(raise_from_sink)
assert seeder._emit_event("assets.seed.error", {"message": "failure"}) is None
# ---------------------------------------------------------------------------
# _reset_to_idle
# ---------------------------------------------------------------------------
class TestResetToIdle:
def test_sets_idle_and_clears_progress(self, seeder):
"""_reset_to_idle should move state to IDLE and snapshot progress."""
progress = Progress(scanned=10, total=20, created=5, skipped=3)
seeder._state = State.RUNNING
seeder._progress = progress
with seeder._lock:
seeder._reset_to_idle()
assert seeder._state is State.IDLE
assert seeder._progress is None
assert seeder._last_progress is progress
def test_noop_when_progress_already_none(self, seeder):
"""_reset_to_idle should handle None progress gracefully."""
seeder._state = State.CANCELLING
seeder._progress = None
with seeder._lock:
seeder._reset_to_idle()
assert seeder._state is State.IDLE
assert seeder._progress is None
assert seeder._last_progress is None
# ---------------------------------------------------------------------------
# enqueue_scan – immediate start when idle
# ---------------------------------------------------------------------------
class TestEnqueueScanStartsImmediately:
def test_starts_when_idle(self, seeder):
with patch.object(seeder, "start", return_value=True) as mock:
assert (
seeder.enqueue_scan(
roots=("output",), phase=ScanPhase.ENRICH, compute_hashes=True
)
is True
)
mock.assert_called_once_with(
roots=("output",),
phase=ScanPhase.ENRICH,
prune_first=False,
compute_hashes=True,
)
def test_no_pending_when_started_immediately(self, seeder):
with patch.object(seeder, "start", return_value=True):
seeder.enqueue_scan(roots=("output",), phase=ScanPhase.ENRICH)
assert seeder._pending_scan is None
# ---------------------------------------------------------------------------
# enqueue_scan – queuing when busy
# ---------------------------------------------------------------------------
class TestEnqueueScanQueuesWhenBusy:
def test_queues_when_busy(self, seeder):
with patch.object(seeder, "start", return_value=False):
result = seeder.enqueue_scan(
roots=("models",), phase=ScanPhase.ENRICH, compute_hashes=False
)
assert result is False
assert seeder._pending_scan == {
"roots": ("models",),
"phase": ScanPhase.ENRICH,
"compute_hashes": False,
}
def test_queues_preserves_compute_hashes_true(self, seeder):
with patch.object(seeder, "start", return_value=False):
seeder.enqueue_scan(
roots=("input",), phase=ScanPhase.ENRICH, compute_hashes=True
)
assert seeder._pending_scan["compute_hashes"] is True
# ---------------------------------------------------------------------------
# enqueue_scan – merging when a pending request already exists
# ---------------------------------------------------------------------------
class TestEnqueueScanMergesPending:
def _make_busy(self, seeder):
return patch.object(seeder, "start", return_value=False)
def test_merges_roots(self, seeder):
"""A second enqueue should merge roots with the existing pending request."""
with self._make_busy(seeder):
seeder.enqueue_scan(roots=("models",), phase=ScanPhase.ENRICH)
seeder.enqueue_scan(roots=("output",), phase=ScanPhase.FAST)
merged = set(seeder._pending_scan["roots"])
assert merged == {"models", "output"}
assert seeder._pending_scan["phase"] is ScanPhase.FULL
def test_merges_overlapping_roots(self, seeder):
"""Duplicate roots should be deduplicated."""
with self._make_busy(seeder):
seeder.enqueue_scan(roots=("models", "input"), phase=ScanPhase.ENRICH)
seeder.enqueue_scan(roots=("input", "output"), phase=ScanPhase.ENRICH)
merged = set(seeder._pending_scan["roots"])
assert merged == {"models", "input", "output"}
def test_compute_hashes_sticky_true(self, seeder):
"""Once compute_hashes is True it should stay True after merging."""
with self._make_busy(seeder):
seeder.enqueue_scan(
roots=("models",), phase=ScanPhase.ENRICH, compute_hashes=True
)
seeder.enqueue_scan(
roots=("output",), phase=ScanPhase.ENRICH, compute_hashes=False
)
assert seeder._pending_scan["compute_hashes"] is True
def test_compute_hashes_upgrades_to_true(self, seeder):
"""A later enqueue with compute_hashes=True should upgrade the pending request."""
with self._make_busy(seeder):
seeder.enqueue_scan(
roots=("models",), phase=ScanPhase.ENRICH, compute_hashes=False
)
seeder.enqueue_scan(
roots=("output",), phase=ScanPhase.ENRICH, compute_hashes=True
)
assert seeder._pending_scan["compute_hashes"] is True
def test_compute_hashes_stays_false(self, seeder):
"""If both enqueues have compute_hashes=False it stays False."""
with self._make_busy(seeder):
seeder.enqueue_scan(
roots=("models",), phase=ScanPhase.ENRICH, compute_hashes=False
)
seeder.enqueue_scan(
roots=("output",), phase=ScanPhase.ENRICH, compute_hashes=False
)
assert seeder._pending_scan["compute_hashes"] is False
def test_triple_merge(self, seeder):
"""Three successive enqueues should all merge correctly."""
with self._make_busy(seeder):
seeder.enqueue_scan(
roots=("models",), phase=ScanPhase.ENRICH, compute_hashes=False
)
seeder.enqueue_scan(
roots=("input",), phase=ScanPhase.ENRICH, compute_hashes=False
)
seeder.enqueue_scan(
roots=("output",), phase=ScanPhase.ENRICH, compute_hashes=True
)
merged = set(seeder._pending_scan["roots"])
assert merged == {"models", "input", "output"}
assert seeder._pending_scan["compute_hashes"] is True
class TestPendingScanDrain:
@patch("app.assets.seeder.dependencies_available", return_value=True)
@patch("app.assets.seeder.get_owned_prefixes", return_value=[])
@patch("app.assets.seeder.sync_root_safely", return_value=set())
@patch("app.assets.seeder.collect_paths_for_roots", return_value=[])
@patch("app.assets.seeder.build_asset_specs", return_value=([], {}, 0))
def test_pending_scan_starts_after_scan(self, *_mocks):
seeder = _AssetSeeder()
seeder._pending_scan = {
"roots": ("output",),
"phase": ScanPhase.FULL,
"compute_hashes": True,
}
real_start = seeder.start
with patch.object(seeder, "start", wraps=real_start) as mock_start:
seeder.start_fast(roots=("models",))
seeder.wait(timeout=5)
seeder.wait(timeout=5)
assert mock_start.call_args_list[-1] == call(
roots=("output",),
phase=ScanPhase.FULL,
prune_first=False,
compute_hashes=True,
_start_paused=False,
)
assert seeder._pending_scan is None
@patch("app.assets.seeder.dependencies_available", return_value=True)
def test_pause_is_preserved_when_pending_scan_drains(self, _dependencies):
seeder = _AssetSeeder()
phase_ready = threading.Event()
allow_phase_return = threading.Event()
drained_phase_calls: list[tuple[str, ...]] = []
def gated_enrich(roots):
if roots == ("models",):
phase_ready.set()
allow_phase_return.wait(timeout=5)
allow_phase_return.clear()
else:
drained_phase_calls.append(roots)
phase_ready.set()
allow_phase_return.wait(timeout=5)
return False, 0
seeder._pending_scan = {
"roots": ("output",),
"phase": ScanPhase.ENRICH,
"compute_hashes": False,
}
real_start = seeder.start
def start_and_signal(**kwargs):
started = real_start(**kwargs)
if started and kwargs["roots"] == ("output",):
if seeder._state is State.PAUSED:
phase_ready.set()
else:
phase_ready.wait(timeout=5)
return started
observed = {}
with (
patch.object(seeder, "_log_scan_config"),
patch.object(seeder, "_run_enrich_phase", side_effect=gated_enrich),
patch.object(seeder, "start", side_effect=start_and_signal),
):
try:
assert seeder.start(
roots=("models",), phase=ScanPhase.ENRICH
) is True
assert phase_ready.wait(timeout=5)
assert seeder.pause() is True
phase_ready.clear()
allow_phase_return.set()
assert phase_ready.wait(timeout=5)
with seeder._lock:
state_before_resume = seeder._state
gate_set_before_resume = seeder._run_gate.is_set()
calls_before_resume = len(drained_phase_calls)
phase_ready.clear()
resume_return = seeder.resume()
if calls_before_resume == 0:
assert phase_ready.wait(timeout=5)
allow_phase_return.set()
assert seeder.wait(timeout=5)
observed = {
"state_before_resume": state_before_resume,
"gate_set_before_resume": gate_set_before_resume,
"resume_return": resume_return,
"drained_phase_calls_before_resume": calls_before_resume,
"drained_phase_calls_after_resume": len(drained_phase_calls),
}
finally:
allow_phase_return.set()
seeder.resume()
seeder.wait(timeout=5)
assert observed == {
"state_before_resume": State.PAUSED,
"gate_set_before_resume": False,
"resume_return": True,
"drained_phase_calls_before_resume": 0,
"drained_phase_calls_after_resume": 1,
}, (
f"state_before_resume={observed['state_before_resume']!r}, "
f"gate_set_before_resume={observed['gate_set_before_resume']!r}, "
f"resume_return={observed['resume_return']!r}, "
"drained_phase_calls_before_resume="
f"{observed['drained_phase_calls_before_resume']!r}, "
"drained_phase_calls_after_resume="
f"{observed['drained_phase_calls_after_resume']!r}"
)
@patch("app.assets.seeder.dependencies_available", return_value=True)
@patch("app.assets.seeder.get_owned_prefixes", return_value=[])
@patch("app.assets.seeder.sync_root_safely", return_value=set())
@patch("app.assets.seeder.collect_paths_for_roots", return_value=[])
@patch("app.assets.seeder.build_asset_specs", return_value=([], {}, 0))
def test_pending_cleared_even_when_start_fails(self, *_mocks):
seeder = _AssetSeeder()
seeder._pending_scan = {
"roots": ("output",),
"phase": ScanPhase.ENRICH,
"compute_hashes": False,
}
real_start = seeder.start
def start_initial_scan_only(**kwargs):
if kwargs["roots"] == ("models",):
return real_start(**kwargs)
return False
with patch.object(seeder, "start", side_effect=start_initial_scan_only):
seeder.start_fast(roots=("models",))
seeder.wait(timeout=5)
assert seeder._pending_scan is None
@patch("app.assets.seeder.dependencies_available", return_value=True)
@patch("app.assets.seeder.get_owned_prefixes", return_value=[])
@patch("app.assets.seeder.sync_root_safely", return_value=set())
@patch("app.assets.seeder.collect_paths_for_roots", return_value=[])
@patch("app.assets.seeder.build_asset_specs", return_value=([], {}, 0))
def test_no_drain_when_no_pending(self, *_mocks):
seeder = _AssetSeeder()
assert seeder._pending_scan is None
real_start = seeder.start
with patch.object(seeder, "start", wraps=real_start) as mock_start:
seeder.start_fast(roots=("models",))
seeder.wait(timeout=5)
assert mock_start.call_count == 1
# ---------------------------------------------------------------------------
# Thread-safety of enqueue_scan
# ---------------------------------------------------------------------------
class TestEnqueueScanThreadSafety:
def test_concurrent_enqueues(self, seeder):
"""Multiple threads enqueuing should not lose roots."""
with patch.object(seeder, "start", return_value=False):
barrier = threading.Barrier(3)
def enqueue(root):
barrier.wait()
seeder.enqueue_scan(
roots=(root,), phase=ScanPhase.ENRICH, compute_hashes=False
)
threads = [
threading.Thread(target=enqueue, args=(r,))
for r in ("models", "input", "output")
]
for t in threads:
t.start()
for t in threads:
t.join(timeout=5)
merged = set(seeder._pending_scan["roots"])
assert merged == {"models", "input", "output"}
You can’t perform that action at this time.