review: add unit test if pvc has finalizer · cloudnative-pg/cloudnative-pg@6654be9 · GitHub
Skip to content

Commit 6654be9

Browse files
committed
review: add unit test if pvc has finalizer
pvc usually have finalizer to have pod deleted first. Delete the PVC here works because we are using kubernetes client API, which sends the delete request and returns after kubernetes accepts it, add comments here and unit test, to make sure no one in future update the code to ensure the PVC is deleted before deleting pod Signed-off-by: Tao Li <tao.li@enterprisedb.com>
1 parent 0a66b12 commit 6654be9

2 files changed

Lines changed: 27 additions & 3 deletions

File tree

‎internal/cmd/plugin/destroy/destroy.go‎

Lines changed: 4 additions & 3 deletions

‎internal/cmd/plugin/destroy/destroy_test.go‎

Lines changed: 23 additions & 0 deletions

0 commit comments

Comments
 (0)