FilesExpand file tree

 main

/

ComplexConditionGood.java

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

27 lines (22 loc) · 627 Bytes

 main

/

ComplexConditionGood.java

Copy path

Top

File metadata and controls

• Code
• Blame

27 lines (22 loc) · 627 Bytes

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

public class Dialog

{

// ...

private void validate() {

if(idIsEmpty() || (noPartnerId() && parameterLengthInvalid())){ // GOOD: Condition is simpler

disableOKButton();

} else {

enableOKButton();

}

}

private boolean idIsEmpty(){

return id != null && id.length() == 0;

}

private boolean noPartnerId(){

return partner == null || partner.id == -1;

}

private boolean parameterLengthInvalid(){

return (option == Options.SHORT && parameter.length() == 0) ||

(option == Options.LONG && parameter.length() < 8);

}

// ...

}