Comparing master...move_logic_into_glide_node · bumptech/glide · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bumptech/glide
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: bumptech/glide
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: move_logic_into_glide_node
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 9 files changed
  • 1 contributor

Commits on Oct 2, 2023

  1. Make Placeholder a type that can be convered to Painter 

    This removes the deprecated Composable variant of Placeholder. Users who
require that functionality should instead use GlideSubcomposition. It's
useful to remove this now because it allows for a much simpler
Placholder interface and it unblocks us from moving most of GlideImage
into GlideModifier. In turn that will let us expose GlideModifier as a
real composable API component.
    @sjudd
    sjudd committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    9eb82a3 View commit details
    Browse the repository at this point in the history

  2. Move loading logic into GlideModifier 

    Breaking change - this will add the default transformation to
GlideSubcomposition where previously there wasn't one.

Moving more logic into GlideNode simplifies GlideImage a bit and it
moves us closer to exposing a Modifier based API.
    @sjudd
    sjudd committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    582077d View commit details
    Browse the repository at this point in the history
Loading