FilesExpand file tree

 main

/

ShouldUseWithStatement.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

39 lines (34 loc) · 1.16 KB

 main

/

ShouldUseWithStatement.ql

Copy path

Top

File metadata and controls

• Code
• Blame

39 lines (34 loc) · 1.16 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

/**

* @name Should use a 'with' statement

* @description Using a 'try-finally' block to ensure only that a resource is closed makes code more

* difficult to read.

* @kind problem

* @tags maintainability

* readability

* convention

* @problem.severity recommendation

* @sub-severity high

* @precision very-high

* @id py/should-use-with

*/

import python

predicate calls_close(Call c) { exists(Attribute a | c.getFunc() = a and a.getName() = "close") }

predicate only_stmt_in_finally(Try t, Call c) {

exists(ExprStmt s |

t.getAFinalstmt() = s and s.getValue() = c and strictcount(t.getAFinalstmt()) = 1

)

}

predicate points_to_context_manager(ControlFlowNode f, ClassValue cls) {

forex(Value v | f.pointsTo(v) | v.getClass() = cls) and

cls.isContextManager()

}

from Call close, Try t, ClassValue cls

where

only_stmt_in_finally(t, close) and

calls_close(close) and

exists(ControlFlowNode f | f = close.getFunc().getAFlowNode().(AttrNode).getObject() |

points_to_context_manager(f, cls)

)

select close,

"Instance of context-manager class $@ is closed in a finally block. Consider using 'with' statement.",

cls, cls.getName()