FilesExpand file tree

 main

/

IncorrectlyOverriddenMethod.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

31 lines (29 loc) · 1.03 KB

 main

/

IncorrectlyOverriddenMethod.ql

Copy path

Top

File metadata and controls

• Code
• Blame

31 lines (29 loc) · 1.03 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

/**

* @name Mismatch between signature and use of an overriding method

* @description Method has a different signature from the overridden method and, if it were called, would be likely to cause an error.

* @kind problem

* @tags maintainability

* @problem.severity error

* @sub-severity low

* @precision high

* @id py/inheritance/incorrect-overriding-signature

*/

import python

import Expressions.CallArgs

from Call call, FunctionValue func, FunctionValue overridden, string problem

where

func.overrides(overridden) and

(

wrong_args(call, func, _, problem) and

correct_args_if_called_as_method(call, overridden)

or

exists(string name |

illegally_named_parameter(call, func, name) and

problem = "an argument named '" + name + "'" and

overridden.getScope().getAnArg().(Name).getId() = name

)

)

select func,

"Overriding method signature does not match $@, where it is passed " + problem +

". Overridden method $@ is correctly specified.", call, "here", overridden,

overridden.descriptiveString()