Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 49
Expand file tree
/
Copy pathtest_push_parser.cpp
More file actions
595 lines (517 loc) · 16.5 KB
/
Copy pathtest_push_parser.cpp
File metadata and controls
595 lines (517 loc) · 16.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
//
// Copyright (c) 2026 Marcelo Zimbres Silva (mzimbres@gmail.com),
// Ruben Perez Hidalgo (rubenperez038 at gmail dot com)
//
// Distributed under the Boost Software License, Version 1.0. (See accompanying
// file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
//
#include <boost/redis/push_parser.hpp>
#include <boost/core/lightweight_test.hpp>
#include <boost/system/error_code.hpp>
#include "sansio_utils.hpp"
#include <iterator>
#include <optional>
#include <vector>
#if (__cpp_lib_ranges >= 201911L) && (__cpp_lib_concepts >= 202002L)
#define BOOST_REDIS_TEST_RANGE_CONCEPTS
#include <ranges>
#endif
using namespace boost::redis;
using detail::tree_from_resp3;
// Operators
namespace boost::redis {
std::ostream& operator<<(std::ostream& os, const push_view& v)
{
os << "push_view { .channel=" << v.channel;
if (v.pattern)
os << ", .pattern=" << *v.pattern;
return os << ", .payload=" << v.payload << " }";
}
bool operator==(const push_view& lhs, const push_view& rhs) noexcept
{
return lhs.channel == rhs.channel && lhs.pattern == rhs.pattern && lhs.payload == rhs.payload;
}
} // namespace boost::redis
namespace {
// --- Only valid messages ---
void test_one_message()
{
auto nodes = tree_from_resp3({">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n"});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_several_messages()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n$5\r\nfirst\r\n$2\r\nHi\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$3\r\nBye\r\n",
});
push_parser p{nodes};
const push_view expected[] = {
{"first", std::nullopt, "Hi" },
{"second", std::nullopt, "Bye"},
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_one_pmessage()
{
auto nodes = tree_from_resp3(
{">4\r\n$8\r\npmessage\r\n$6\r\nmycha*\r\n$6\r\nmychan\r\n$5\r\nHello\r\n"});
push_parser p{nodes};
const push_view expected[] = {
{"mychan", "mycha*", "Hello"},
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_mixed_valid()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n$3\r\nch1\r\n$4\r\nmsg1\r\n",
">4\r\n$8\r\npmessage\r\n$1\r\n*\r\n$3\r\nch2\r\n$4\r\nmsg2\r\n",
">3\r\n$7\r\nmessage\r\n$3\r\nch3\r\n$4\r\nmsg3\r\n",
});
push_parser p{nodes};
const push_view expected[] = {
{"ch1", std::nullopt, "msg1"},
{"ch2", "*", "msg2"},
{"ch3", std::nullopt, "msg3"},
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_message_empty_fields()
{
auto nodes = tree_from_resp3({">3\r\n$7\r\nmessage\r\n$0\r\n\r\n$0\r\n\r\n"});
push_parser p{nodes};
const push_view expected[] = {
{"", std::nullopt, ""},
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_pmessage_empty_fields()
{
auto nodes = tree_from_resp3({">4\r\n$8\r\npmessage\r\n$0\r\n\r\n$0\r\n\r\n$0\r\n\r\n"});
push_parser p{nodes};
const push_view expected[] = {
{"", "", ""},
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// --- Message skipping (valid, expected messages we don't care about) ---
// Anything that is not a RESP3 push is skipped.
// Concretely, pushes in RESP2 used to be arrays. We don't support these
void test_skip_type_array()
{
auto nodes = tree_from_resp3({
"*3\r\n$7\r\nmessage\r\n$5\r\nfirst\r\n$5\r\nValue\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Might happen if a SUBSCRIBE call fails
void test_skip_type_simple_error()
{
auto nodes = tree_from_resp3({
"-ERR foo\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Might happen when using MONITOR
void test_skip_type_simple_string()
{
auto nodes = tree_from_resp3({
"+MONITOR output\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Edge case: other RESP3 types are skipped
void test_skip_type_other()
{
auto nodes = tree_from_resp3({
"%1\r\n$3\r\nkey\r\n$5\r\nvalue\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// The push first field is not 'message' or 'pmessage' (e.g. subscribe confirmations)
void test_skip_msgtype_subscribe_confirmations()
{
auto nodes = tree_from_resp3({
">3\r\n$9\r\nsubscribe\r\n$6\r\nmychan\r\n:1\r\n",
">3\r\n$11\r\nunsubscribe\r\n$6\r\nmychan\r\n:1\r\n",
">3\r\n$10\r\npsubscribe\r\n$5\r\np*tt*\r\n:1\r\n",
">3\r\n$12\r\npunsubscribe\r\n$5\r\np*tt*\r\n:1\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Message type string, but with an unknown value (not 'message' or 'pmessage')
void test_skip_msgtype_unknown()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nunknown\r\n$4\r\nchan\r\n$4\r\nbody\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Message type is an empty string
void test_skip_msgtype_empty()
{
auto nodes = tree_from_resp3({
">3\r\n$0\r\n\r\n$4\r\nchan\r\n$4\r\nbody\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Message type is not a string (e.g. array)
void test_skip_msgtype_not_string()
{
auto nodes = tree_from_resp3({
">3\r\n*1\r\n$3\r\nfoo\r\n$5\r\nHello\r\n$5\r\nworld\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// The message ends before the message type
void test_skip_msgtype_eof()
{
auto nodes = tree_from_resp3({
">0\r\n", // end of message manifests as another message starting
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
">0\r\n", // end of message manifests as the end of the range
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Pattern is not a string
void test_skip_pattern_not_string()
{
auto nodes = tree_from_resp3({
">4\r\n$8\r\npmessage\r\n*1\r\n$3\r\nfoo\r\n$6\r\nmychan\r\n$5\r\nHello\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// The message ends before the pattern field
void test_skip_pattern_eof()
{
auto nodes = tree_from_resp3({
">1\r\n$8\r\npmessage\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
">1\r\n$8\r\npmessage\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Channel not a string
void test_skip_channel_not_string_message()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n*1\r\n$3\r\nfoo\r\n$5\r\nHello\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_skip_channel_not_string_pmessage()
{
auto nodes = tree_from_resp3({
">4\r\n$8\r\npmessage\r\n$1\r\n*\r\n*1\r\n$3\r\nfoo\r\n$5\r\nHello\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Message ends before channel
void test_skip_channel_eof_message()
{
auto nodes = tree_from_resp3({
">1\r\n$7\r\nmessage\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
">1\r\n$7\r\nmessage\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_skip_channel_eof_pmessage()
{
auto nodes = tree_from_resp3({
">2\r\n$8\r\npmessage\r\n$1\r\n*\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
">2\r\n$8\r\npmessage\r\n$1\r\n*\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Payload not a string
void test_skip_payload_not_string_message()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n*1\r\n$3\r\nfoo\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_skip_payload_not_string_pmessage()
{
auto nodes = tree_from_resp3({
">4\r\n$8\r\npmessage\r\n$1\r\n*\r\n$6\r\nsecond\r\n*1\r\n$3\r\nfoo\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Message ends before payload
void test_skip_payload_eof_pmessage()
{
auto nodes = tree_from_resp3({
">3\r\n$8\r\npmessage\r\n$1\r\n*\r\n$3\r\nch2\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
">3\r\n$8\r\npmessage\r\n$1\r\n*\r\n$3\r\nch2\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_skip_payload_eof_message()
{
auto nodes = tree_from_resp3({
">2\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
">2\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// Message is longer than expected
void test_skip_longer_message()
{
auto nodes = tree_from_resp3({
">4\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n$1\r\nx\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_skip_longer_pmessage()
{
auto nodes = tree_from_resp3({
">5\r\n$8\r\npmessage\r\n$1\r\n*\r\n$3\r\nch2\r\n$4\r\nmsg2\r\n$1\r\nx\r\n",
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// --- Mixes of valid and skipped messages ---
void test_only_skipped()
{
auto nodes = tree_from_resp3({
"+foo\r\n",
});
push_parser p{nodes};
std::vector<push_view> expected;
BOOST_TEST_ALL_EQ(p.begin(), p.end(), expected.begin(), expected.end());
}
void test_valid_skipped()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
"-ERR foo\r\n",
});
push_parser p{nodes};
constexpr push_view expected[] = {
{"second", std::nullopt, "Hello"}
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
void test_valid_skipped_mix()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n$3\r\nch1\r\n$4\r\nmsg1\r\n",
"+MONITOR\r\n",
">3\r\n$9\r\nsubscribe\r\n$4\r\nchan\r\n:1\r\n",
">3\r\n$7\r\nmessage\r\n$3\r\nch2\r\n$4\r\nmsg2\r\n",
">3\r\n$7\r\nmessage\r\n$3\r\nch3\r\n$4\r\nmsg3\r\n",
"%1\r\n$3\r\nkey\r\n$5\r\nvalue\r\n",
});
push_parser p{nodes};
const push_view expected[] = {
{"ch1", std::nullopt, "msg1"},
{"ch2", std::nullopt, "msg2"},
{"ch3", std::nullopt, "msg3"},
};
BOOST_TEST_ALL_EQ(p.begin(), p.end(), std::begin(expected), std::end(expected));
}
// --- Edge cases ---
void test_empty()
{
auto nodes = tree_from_resp3({});
push_parser p{nodes};
std::vector<push_view> expected;
BOOST_TEST_ALL_EQ(p.begin(), p.end(), expected.begin(), expected.end());
}
// --- The range interface works as expected ---
#ifdef BOOST_REDIS_TEST_RANGE_CONCEPTS
static_assert(std::ranges::input_range<push_parser>);
static_assert(std::input_iterator<push_parser::iterator>);
#endif
void test_range_interface()
{
auto nodes = tree_from_resp3({
">3\r\n$7\r\nmessage\r\n$6\r\nsecond\r\n$5\r\nHello\r\n",
});
// Iterator default construction
{
push_parser p{nodes};
push_parser::iterator it;
BOOST_TEST(it == p.end());
}
// Iterator comparison
{
push_parser p{nodes};
BOOST_TEST(p.begin() == p.begin());
BOOST_TEST(p.begin() != p.end());
BOOST_TEST(p.end() == p.end());
}
// Iterator prefix increment
{
push_parser p{nodes};
auto it = p.begin();
++it;
BOOST_TEST(it == p.end());
}
// Iterator postfix increment
{
push_parser p{nodes};
auto it = p.begin();
it++;
BOOST_TEST(it == p.end());
}
// Iterator dereference
{
push_parser p{nodes};
auto it = p.begin();
auto value = *it;
BOOST_TEST_EQ(value.payload, "Hello");
}
// Iterator operator->
{
push_parser p{nodes};
auto it = p.begin();
BOOST_TEST_EQ(it->payload, "Hello");
}
}
} // namespace
int main()
{
test_one_message();
test_several_messages();
test_one_pmessage();
test_mixed_valid();
test_message_empty_fields();
test_pmessage_empty_fields();
test_skip_type_array();
test_skip_type_simple_error();
test_skip_type_simple_string();
test_skip_type_other();
test_skip_msgtype_subscribe_confirmations();
test_skip_msgtype_unknown();
test_skip_msgtype_empty();
test_skip_msgtype_not_string();
test_skip_msgtype_eof();
test_skip_pattern_not_string();
test_skip_pattern_eof();
test_skip_channel_not_string_message();
test_skip_channel_not_string_pmessage();
test_skip_channel_eof_message();
test_skip_channel_eof_pmessage();
test_skip_payload_not_string_message();
test_skip_payload_not_string_pmessage();
test_skip_payload_eof_message();
test_skip_payload_eof_pmessage();
test_skip_longer_message();
test_skip_longer_pmessage();
test_skip_longer_pmessage();
test_only_skipped();
test_valid_skipped();
test_valid_skipped_mix();
test_empty();
test_range_interface();
return boost::report_errors();
}
You can’t perform that action at this time.
