fix(model): register ListRecord.Field adapter in GsonFactory · bkyryliuk/java-slack-sdk@9bea9ac · GitHub
Skip to content

Commit 9bea9ac

Browse files
committed
fix(model): register ListRecord.Field adapter in GsonFactory
slackapi#1590 added GsonListRecordFieldFactory to handle array-shaped list_record field messages, but only under slack-api-model tests. The production GsonFactory never registered it, so conversations.replies still fails with Expected BEGIN_OBJECT but was BEGIN_ARRAY on Slack List unfurls (slackapi#1587, slackapi#1653, reproduced in slackapi#1644). Move the factory to slack-api-model main next to the other model adapters and register it in GsonFactory.registerTypeAdapters.
1 parent 699b7eb commit 9bea9ac

3 files changed

Lines changed: 75 additions & 1 deletion

File tree

‎slack-api-client/src/main/java/com/slack/api/util/json/GsonFactory.java‎

Lines changed: 3 additions & 1 deletion
Lines changed: 72 additions & 0 deletions

slack-api-model/src/test/java/test_locally/util/list/GsonListRecordFieldFactory.java renamed to slack-api-model/src/main/java/com/slack/api/util/json/GsonListRecordFieldFactory.java

File renamed without changes.

0 commit comments

Comments
 (0)