arturoc added 2 commits

April 19, 2022 15:05


          Iterator over all the enabled options

e2ec673

This adds a new function that returns an iterator over all the enabled flags.

This implementation takes into account combined flags like the ones described in: bitflags#204 (comment)

It uses an `impl Iterator` as return type because using an specific Iter type implies using const generics which are not supported in earlier versions of rust and adding a const to the trait in order to express the correct dimension of the array as can be seen in the last solution proposed in bitflags#204.

This superseeds bitflags#204


          Merge branch 'fix_serde_tests' into iterators

abc1e0c

KodrAus commented Apr 20, 2022

Member

Ah this is an interesting approach 🤔 Thanks for exploring this @arturoc! I'd love to see some test cases that demonstrate how it works, and ideally we'd be able to replace our debug implementation with it (that might require an implementation that yielded &'static strs instead of flags though, but we could call that iter_names or something.


          iterators: add tests

229f196

arturoc commented Apr 20, 2022

Author

Ah yes I forgot to bring the tests from the previous implementation, just pushed them in a new commit

arturoc commented Apr 20, 2022

Author

Note how in the first test the flags appear in the wrong order due to the optimization to not go through all the options in every iteration. Removing that would show the flags in the correct order but would be slower for bitflags with a lot of options. I can try to do some benchmarks to understand if it's worth

arturoc added 4 commits

April 20, 2022 13:34


          Merge branch 'main' of https://github.com/bitflags/bitflags into iter…

c18695a

…ators


          iterators: preserve order of flags

4ba731a


          iterator: options array doesn't need to be mut

c5a5c15


          iterators: make options array const

46fbbc3

arturoc commented Apr 20, 2022

Author

Just figured a better way to optimize the iterator method so it preserves the order of the flags and the options array is a const now.

arturoc added 2 commits

April 20, 2022 14:09


          iterators: remove unnecesary check

00058b1


          iterators: no need to iterate over a range anymore

5f753e1

KodrAus reviewed

Apr 23, 2022

View reviewed changes

src/lib.rs

+                          struct Flags: u32 {
+                              const ONE  = 0b001;
+                              const TWO  = 0b010;
+                              const THREE = 0b100;

KodrAus Apr 23, 2022

Member

Would it be possible to add a cfg'd-out flag to this as well just to make sure we handle those? Something like:

#[cfg(windows)]
const FOUR_WIN = 0b1000;
#[cfg(unix)]
const FOUR_UNIX = 0b10000;

and then use those matching cfgs to check that we iterate over those flags when they're available, but don't when they're not?

KodrAus commented Apr 23, 2022

Member

Thanks for working on this @arturoc! It's a nice simple approach you've ended up with. I like it!

KodrAus mentioned this pull request

Apr 23, 2022

Implement a .len() function #274

Closed


          iterator: add cfg to tests

arturoc commented Apr 26, 2022

Author

Thanks! have added a test for cfg

KodrAus approved these changes

Apr 28, 2022

View reviewed changes

KodrAus left a comment

Member

Nicely done! This looks good to me.

KodrAus merged commit 0141a07 into bitflags:main

Apr 28, 2022

This was referenced May 4, 2022

Add ability to iterate through flags #28

Closed

Constants deserialization #147

Closed

Add support for iterating set bits in flags. #152

Closed

KodrAus mentioned this pull request

Mar 10, 2023

Prepare for 2.0.0 release #306

Merged

Sunbelt Computer Software

PL/B Language Development and Support