Progress bar bug on large screen · Issue #202 · bbc/react-transcript-editor · GitHub
Skip to content

Progress bar bug on large screen  #202

Open

Description

@pietrop

Describe the bug

The progress bar looks off on large screens (27-inch) - see screenshot

To Reproduce
Steps to reproduce the behavior:

Load demo storybook app on a large screen, eg 27-inch

Expected behavior

For the progress bar to look the same on a larger screen.

Screenshots

bug-progress-bar

Additional context

NA

Activity

  1. self-assigned this
    on Oct 7, 2019
  2. pietrop commented on Oct 7, 2019

    @pietrop
    ContributorAuthor

    is this what is causing the issue /packages/components/media-player/src/ProgressBar.module.scss#L3?

    $slider-width-number: 1440;

    is 1440 supposed to be a max screen width?

  3. emettely commented on Oct 7, 2019

    @emettely
    Contributor

    Also, weirdly maybe unrelated - I'm seeing a gap in progress bar when progressing further into the video.
    Screen Shot 2019-10-07 at 13 37 32

  4. pietrop commented on Oct 7, 2019

    @pietrop
    ContributorAuthor

    Interesting, I wasn't able to reproduce that @emettely

    I did noticed tho that if I change slider-width-number to be 2290 then the problem is fixed (?) at least on a 27in screen.

    $slider-width-number: 2290;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions