Merge pull request #324 from atom/mkt-fix-mouseup-on-empty-stagingview-area

Michelle Tilley · web-flow · commit fe5fcd5b0b37 · 2016-11-23T11:40:04.000-08:00
Fix mouseup handler in StagingView
diff --git a/lib/views/staging-view.js b/lib/views/staging-view.js
@@ -162,9 +162,11 @@ export default class StagingView {
   }
 
   mouseup () {
-    this.mouseSelectionInProgress = false
-    this.selection.coalesce()
-    this.onDidChangeSelectedItem()
+    if (this.mouseSelectionInProgress) {
+      this.mouseSelectionInProgress = false
+      this.selection.coalesce()
+      this.onDidChangeSelectedItem()
+    }
   }
 
   render () {

Original file line number	Diff line number	Diff line change
`@@ -162,9 +162,11 @@ export default class StagingView {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`mouseup () {`
`165`		`- this.mouseSelectionInProgress = false`
`166`		`- this.selection.coalesce()`
`167`		`- this.onDidChangeSelectedItem()`
	`165`	`+ if (this.mouseSelectionInProgress) {`
	`166`	`+ this.mouseSelectionInProgress = false`
	`167`	`+ this.selection.coalesce()`
	`168`	`+ this.onDidChangeSelectedItem()`
	`169`	`+ }`
`168`	`170`	`}`
`169`	`171`
`170`	`172`	`render () {`