According to the docs, https://astroplan.readthedocs.io/en/latest/api/astroplan.Observer.html#astroplan.Observer Observer has parameters of elevation, longitude, and latitude as attributes, but this is not true. There is of course an implicit elevation instance in the repr and inside the location attribute.
|
if location is None and (latitude is not None and |
|
longitude is not None): |
|
self.location = EarthLocation.from_geodetic(longitude, latitude, |
|
elevation) |
|
|
|
elif isinstance(location, EarthLocation): |
|
self.location = location |
The location is of type EarthLocation and is added here, but while the other parameters are instantiated, longitude, latitude, and elevation are not. Now since they are based on the location attribute which can presumably change, it would be best if these instances reported the correct and human readable value as astropy.quantity.Quantity instances, even after a change of state.
The linked PR #522 shows my proposed fixes.
According to the docs, https://astroplan.readthedocs.io/en/latest/api/astroplan.Observer.html#astroplan.Observer
Observerhas parameters of elevation, longitude, and latitude as attributes, but this is not true. There is of course an implicit elevation instance in thereprand inside thelocationattribute.astroplan/astroplan/observer.py
Lines 187 to 193 in b3cf553
The location is of type
EarthLocationand is added here, but while the other parameters are instantiated, longitude, latitude, and elevation are not. Now since they are based on thelocationattribute which can presumably change, it would be best if these instances reported the correct and human readable value asastropy.quantity.Quantityinstances, even after a change of state.The linked PR #522 shows my proposed fixes.