{{ message }}
fix(build): resolve capsule artifacts from Cargo target dir - #1810
Draft
joshuajbouw wants to merge 1 commit into
Draft
fix(build): resolve capsule artifacts from Cargo target dir#1810joshuajbouw wants to merge 1 commit into
joshuajbouw wants to merge 1 commit into
Conversation
Closes #1807 Signed-off-by: Joshua J. Bouw <jjb@unicity-labs.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Uses Cargo’s resolved target directory to locate exact capsule WASM artifacts securely.
Changes:
- Resolves build target and cdylib output names.
- Adds fail-closed artifact validation.
- Adds focused artifact-resolution tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+140
to
+153
| fn resolve_wasm_output_name_from_targets<I>(output_names: I, fallback: &str) -> Result<String> | ||
| where | ||
| I: IntoIterator<Item = String>, | ||
| { | ||
| let output_names: Vec<String> = output_names.into_iter().collect(); | ||
| match output_names.as_slice() { | ||
| [] => validate_wasm_output_name(fallback), | ||
| [output_name] => validate_wasm_output_name(output_name), | ||
| _ => bail!( | ||
| "Capsule has {} cdylib targets; refusing to choose an ambiguous WASM artifact", | ||
| output_names.len() | ||
| ), | ||
| } | ||
| } |
Comment on lines
186
to
+190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1807.
Summary
Resolves capsule build artifacts from Cargo's configured target directory instead of assuming a workspace-local
target/tree.Changes
Verification
AI / Tool Assistance
Assisted-by: Codex
AI assistance was used for implementation and tests. The maintainer reviewed the scope and owns the landing decision.
Checklist