Review console code scanning hardening findings by actual trust boundary · Issue #14680 · appwrite/appwrite · GitHub
Skip to content

Review console code scanning hardening findings by actual trust boundary #14680

Open

Description

@loks0n

Retain 16 console findings for remediation/review:

  • OAuth sessionStorage: alert #4051 and alert #4048 contain authorization codes, codeVerifier and optional OAuth client credentials. Review cleanup, lifetime and a server-side exchange; scanner evidence alone does not prove disclosure.
  • Iframe URL alert #4031: withAutoplay permits arbitrary schemes, and docs Markdoc src/blog data attributes reach the player. Restrict to parsed HTTPS YouTube hosts/IDs. Establish an untrusted content writer before calling this exploitable XSS.
  • Regex alert #4027 / alert #4028: package/bundle-ID validation has overlapping dot repetitions; blog list-link preprocessing has ambiguous nested repetitions. Rewrite for bounded input processing and test adversarial lengths. Blog input is currently repository content.
  • Host classification alert #4067 / alert #4078 / alert #4079 / alert #4086: parse hostnames rather than substring-checking Cloud endpoints or acquisition referrers. Preserve regional hosts. These are UI/analytics correctness issues, not a demonstrated server authorization bypass.
  • Raffle alert #4044: Math.random selects promotional winners. Review suitable randomness and whether authoritative selection belongs server-side; this is integrity/fairness hardening.
  • Markdown alert #4038–alert #4043: escape backslashes before pipes. Treat as formatting correctness unless an unsafe downstream renderer introduces an injection boundary.

Alert links: https://github.com/appwrite/appwrite/security/code-scanning (search by the IDs above). Reviewed at ac7f088. Parent: #14675.

Activity

  1. self-assigned this
    on Oct 19, 2026
  2. added
    product / authFixes and upgrades for the Appwrite Auth / Users / Teams services.
    product / databasesFixes and upgrades for the Appwrite Database.
    product / vcsFixes and upgrades for the Appwrite VCS.
    sdk / cliFixes and upgrades for the Appwrite CLI.
    on Oct 19, 2026
  3. loks0n commented on Oct 19, 2026

    @loks0n
    MemberAuthor

    Additional evidence for #4027: exercised the actual isValidKey function extracted from platform-map.ts in an isolated JavaScript context. Invalid inputs with 10 and 20 repeated .A segments took about 1 ms and 13 ms; 30 segments exceeded a 500 ms execution timeout. This reproduces the package-ID validator CPU issue without submitting input to any running service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

product / authFixes and upgrades for the Appwrite Auth / Users / Teams services.product / consoleConsole, UI and UX issuesproduct / databasesFixes and upgrades for the Appwrite Database.product / vcsFixes and upgrades for the Appwrite VCS.sdk / cliFixes and upgrades for the Appwrite CLI.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions