Fix ruff errors

kosiew · kosiew · commit 714aa709d7bb · 2025-04-28T22:10:52.000+08:00
diff --git a/python/tests/test_dataframe.py b/python/tests/test_dataframe.py
@@ -41,7 +41,9 @@
 )
 from pyarrow.csv import write_csv
 
-MB = 1024* 1024
+MB = 1024 * 1024
+
+
 @pytest.fixture
 def ctx():
     return SessionContext()
@@ -116,6 +118,7 @@ def clean_formatter_state():
     """Reset the HTML formatter after each test."""
     reset_formatter()
 
+
 # custom style for testing with html formatter
 class CustomStyleProvider:
     def get_cell_style(self) -> str:
@@ -130,17 +133,17 @@ def get_header_style(self) -> str:
             "padding: 10px; border: 1px solid #3367d6;"
         )
 
+
 def count_table_rows(html_content: str) -> int:
     """Count the number of table rows in HTML content.
-    
     Args:
         html_content: HTML string to analyze
-        
     Returns:
         Number of table rows found (number of <tr> tags)
     """
     return len(re.findall(r"<tr", html_content))
 
+
 def test_select(df):
     df_1 = df.select(
         column("a") + column("b"),
@@ -929,23 +932,17 @@ def get_header_style(self) -> str:
 
 def test_html_formatter_memory(df, clean_formatter_state):
     """Test the memory and row control parameters in DataFrameHtmlFormatter."""
-    configure_formatter(
-        max_memory_bytes = 10,
-        min_rows_display = 1
-    )
+    configure_formatter(max_memory_bytes=10, min_rows_display=1)
     html_output = df._repr_html_()
-   
+
     # Count the number of table rows in the output
     tr_count = count_table_rows(html_output)
     # With a tiny memory limit of 10 bytes, the formatter should display
     # the minimum number of rows (1) plus a message about truncation
     assert tr_count == 2  # 1 for header row, 1 for data row
-    assert "data truncated" in html_output.lower() 
-    
-    configure_formatter(
-        max_memory_bytes = 10*MB,
-        min_rows_display = 1
-    )
+    assert "data truncated" in html_output.lower()
+
+    configure_formatter(max_memory_bytes=10 * MB, min_rows_display=1)
     html_output = df._repr_html_()
     # With larger memory limit and min_rows=2, should display all rows
     tr_count = count_table_rows(html_output)
@@ -954,40 +951,35 @@ def test_html_formatter_memory(df, clean_formatter_state):
     # No truncation message should appear
     assert "data truncated" not in html_output.lower()
 
+
 def test_html_formatter_repr_rows(df, clean_formatter_state):
-    configure_formatter(
-        min_rows_display = 2,
-        repr_rows = 2
-    )
+    configure_formatter(min_rows_display=2, repr_rows=2)
     html_output = df._repr_html_()
-    
+
     tr_count = count_table_rows(html_output)
     # Tabe should have header row (1) + 2 data rows = 3 rows
     assert tr_count == 3
-    
-    configure_formatter(
-        min_rows_display = 2,
-        repr_rows = 3
-    )
+
+    configure_formatter(min_rows_display=2, repr_rows=3)
     html_output = df._repr_html_()
-    
+
     tr_count = count_table_rows(html_output)
     # Tabe should have header row (1) + 3 data rows = 4 rows
     assert tr_count == 4
-   
-    
+
+
 def test_html_formatter_validation():
     # Test validation for invalid parameters
-    
+
     with pytest.raises(ValueError, match="max_cell_length must be a positive integer"):
         DataFrameHtmlFormatter(max_cell_length=0)
-        
+
     with pytest.raises(ValueError, match="max_width must be a positive integer"):
         DataFrameHtmlFormatter(max_width=0)
-        
+
     with pytest.raises(ValueError, match="max_height must be a positive integer"):
         DataFrameHtmlFormatter(max_height=0)
-        
+
     with pytest.raises(ValueError, match="max_memory_bytes must be a positive integer"):
         DataFrameHtmlFormatter(max_memory_bytes=0)
 
@@ -1012,51 +1004,51 @@ def test_configure_formatter(df, clean_formatter_state):
     parameters."""
 
     # these are non-default values
-    MAX_CELL_LENGTH = 10
-    MAX_WIDTH = 500
-    MAX_HEIGHT = 30
-    MAX_MEMORY_BYTES = 3*MB
-    MIN_ROWS_DISPLAY=2
-    REPR_ROWS = 2
-    ENABLE_CELL_EXPANSION = False
-    SHOW_TRUNCATION_MESSAGE = False
-    USE_SHARED_STYLES = False
-    
+    max_cell_length = 10
+    max_width = 500
+    max_height = 30
+    max_memory_bytes = 3 * MB
+    min_rows_display = 2
+    repr_rows = 2
+    enable_cell_expansion = False
+    show_truncation_message = False
+    use_shared_styles = False
+
     reset_formatter()
     formatter_default = get_formatter()
-   
-    assert formatter_default.max_cell_length != MAX_CELL_LENGTH
-    assert formatter_default.max_width != MAX_WIDTH
-    assert formatter_default.max_height != MAX_HEIGHT 
-    assert formatter_default.max_memory_bytes != MAX_MEMORY_BYTES
-    assert formatter_default.min_rows_display != MIN_ROWS_DISPLAY
-    assert formatter_default.repr_rows != REPR_ROWS
-    assert formatter_default.enable_cell_expansion != ENABLE_CELL_EXPANSION
-    assert formatter_default.show_truncation_message != SHOW_TRUNCATION_MESSAGE
-    assert formatter_default.use_shared_styles != USE_SHARED_STYLES
-     
+
+    assert formatter_default.max_cell_length != max_cell_length
+    assert formatter_default.max_width != max_width
+    assert formatter_default.max_height != max_height
+    assert formatter_default.max_memory_bytes != max_memory_bytes
+    assert formatter_default.min_rows_display != min_rows_display
+    assert formatter_default.repr_rows != repr_rows
+    assert formatter_default.enable_cell_expansion != enable_cell_expansion
+    assert formatter_default.show_truncation_message != show_truncation_message
+    assert formatter_default.use_shared_styles != use_shared_styles
+
     # Configure with custom style provider and additional parameters
     configure_formatter(
-        max_cell_length = MAX_CELL_LENGTH,
-        max_width = MAX_WIDTH,
-        max_height= MAX_HEIGHT,
-        max_memory_bytes=MAX_MEMORY_BYTES,
-        min_rows_display=MIN_ROWS_DISPLAY,
-        repr_rows=REPR_ROWS,
-        enable_cell_expansion = ENABLE_CELL_EXPANSION,
-        show_truncation_message = SHOW_TRUNCATION_MESSAGE,
-        use_shared_styles = USE_SHARED_STYLES
+        max_cell_length=max_cell_length,
+        max_width=max_width,
+        max_height=max_height,
+        max_memory_bytes=max_memory_bytes,
+        min_rows_display=min_rows_display,
+        repr_rows=repr_rows,
+        enable_cell_expansion=enable_cell_expansion,
+        show_truncation_message=show_truncation_message,
+        use_shared_styles=use_shared_styles,
     )
     formatter_custom = get_formatter()
-    assert formatter_custom.max_cell_length == MAX_CELL_LENGTH
-    assert formatter_custom.max_width == MAX_WIDTH
-    assert formatter_custom.max_height == MAX_HEIGHT 
-    assert formatter_custom.max_memory_bytes == MAX_MEMORY_BYTES
-    assert formatter_custom.min_rows_display == MIN_ROWS_DISPLAY
-    assert formatter_custom.repr_rows == REPR_ROWS
-    assert formatter_custom.enable_cell_expansion == ENABLE_CELL_EXPANSION
-    assert formatter_custom.show_truncation_message == SHOW_TRUNCATION_MESSAGE
-    assert formatter_custom.use_shared_styles == USE_SHARED_STYLES
+    assert formatter_custom.max_cell_length == max_cell_length
+    assert formatter_custom.max_width == max_width
+    assert formatter_custom.max_height == max_height
+    assert formatter_custom.max_memory_bytes == max_memory_bytes
+    assert formatter_custom.min_rows_display == min_rows_display
+    assert formatter_custom.repr_rows == repr_rows
+    assert formatter_custom.enable_cell_expansion == enable_cell_expansion
+    assert formatter_custom.show_truncation_message == show_truncation_message
+    assert formatter_custom.use_shared_styles == use_shared_styles
 
 
 def test_get_dataframe(tmp_path):
@@ -1788,4 +1780,3 @@ def test_html_formatter_manual_format_html(clean_formatter_state):
 
     assert "<style>" in local_html_1
     assert "<style>" in local_html_2
-
