fix(@angular/cli): skip downloading temp CLI when running ng update without package names

alan-agius4 · clydin · commit 28b2cd18e3c4 · 2022-10-06T16:21:28.000-04:00
In the case when `ng update` is ran without a package name, an update is not be performed. In this case using the current installed version of the CLI is good enough. Closes #24024 (cherry picked from commit 3202410)
diff --git a/packages/angular/cli/src/commands/update/cli.ts b/packages/angular/cli/src/commands/update/cli.ts
@@ -164,7 +164,8 @@ export class UpdateCommandModule extends CommandModule<UpdateCommandArgs> {
     packageManager.ensureCompatibility();
 
     // Check if the current installed CLI version is older than the latest compatible version.
-    if (!disableVersionCheck) {
+    // Skip when running `ng update` without a package name as this will not trigger an actual update.
+    if (!disableVersionCheck && options.packages?.length) {
       const cliVersionToInstall = await this.checkCLIVersion(
         options.packages,
         options.verbose,
@@ -880,7 +881,7 @@ export class UpdateCommandModule extends CommandModule<UpdateCommandArgs> {
    * @returns the version to install or null when there is no update to install.
    */
   private async checkCLIVersion(
-    packagesToUpdate: string[] | undefined,
+    packagesToUpdate: string[],
     verbose = false,
     next = false,
   ): Promise<string | null> {
diff --git a/packages/angular/cli/src/utilities/package-metadata.ts b/packages/angular/cli/src/utilities/package-metadata.ts
@@ -292,19 +292,12 @@ export async function getNpmPackageJson(
   const { usingYarn = false, verbose = false, registry } = options;
   ensureNpmrc(logger, usingYarn, verbose);
   const { packument } = await import('pacote');
-  const resultPromise = packument(packageName, {
+  const response = packument(packageName, {
     fullMetadata: true,
     ...npmrc,
     ...(registry ? { registry } : {}),
   });
 
-  // TODO: find some way to test this
-  const response = resultPromise.catch((err) => {
-    logger.warn(err.message || err);
-
-    return { requestedName: packageName };
-  });
-
   npmPackageJsonCache.set(packageName, response);
 
   return response;
