You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Angular signal input migration fails with "extends": "@tsconfig/strictest/tsconfig.json" in tsconfig #59348
@wein2011 Thanks for the issue. I tried reproducing this issue, but couldn't reproduce. Is it possible the package for @tsconfig/strictest simply wasn't installed?
I attached a simple reproduction which is based on the standard new Angular project.
The differences are:
tsconfig.json includes the line: "extends": "@tsconfig/strictest/tsconfig.json"
The project migration-test-1 is part of a workspace within the "migration test"/package.json file.
The issue only occurs when using the workspaces feature within package.json which changes the default location of node_modules.
In order to reproduce, please follow these steps:
Unzip the migration test.zip file
$> cd "migration test"
$> npm install
This will create the node_modules folder next to and not within the migration-test-1 folder
$> cd migration-test-1
$> ng generate @angular/core:signal-input-migration
Which directory do you want to migrate? ./
Do you want to migrate as much as possible, even if it may break your build? no
This results in:
Preparing analysis for: tsconfig.app.json..
Tsconfig could not be parsed or is invalid:
File '@tsconfig/strictest/tsconfig.json' not found.
I assume this has to do with the fact that the node_modules are now one level higher. However, this should be ok.
Activity
devversion commentedon Jan 10, 2025
@wein2011 Thanks for the issue. I tried reproducing this issue, but couldn't reproduce. Is it possible the package for
@tsconfig/strictestsimply wasn't installed?Please create a reproduction if possible. Thanks
test: add test to verify extending tsconfig works in signal input mig…
test: add test to verify extending tsconfig works in signal input mig…
test: add test to verify extending tsconfig works in signal input mig…
test: add test to verify extending tsconfig works in signal input mig…
wein2011 commentedon Jan 10, 2025
I attached a simple reproduction which is based on the standard new Angular project.
The differences are:
The issue only occurs when using the workspaces feature within package.json which changes the default location of node_modules.
In order to reproduce, please follow these steps:
This will create the node_modules folder next to and not within the migration-test-1 folder
Which directory do you want to migrate? ./
Do you want to migrate as much as possible, even if it may break your build? no
Preparing analysis for: tsconfig.app.json..
Tsconfig could not be parsed or is invalid:
File '@tsconfig/strictest/tsconfig.json' not found.
I assume this has to do with the fact that the node_modules are now one level higher. However, this should be ok.
migration test.zip
test: add test to verify extending tsconfig works in signal input mig…
angular-automatic-lock-bot commentedon Feb 13, 2025
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.