perf(core): use ngDevMode to tree-shake checkNoChanges (#39964)

arturovt · mhevery · commit 2fbb684b4e73 · 2020-12-04T16:11:34.000-08:00
This commit adds `ngDevMode` guard to run `checkNoChanges` only in dev mode (similar to how things work in other parts of Ivy runtime code). The `ngDevMode` flag helps to tree-shake this code from production builds (in dev mode everything will work as it works right now) to decrease production bundle size. PR Close #39964
diff --git a/goldens/size-tracking/aio-payloads.json b/goldens/size-tracking/aio-payloads.json
@@ -12,7 +12,7 @@
     "master": {
       "uncompressed": {
         "runtime-es2015": 3033,
-        "main-es2015": 447343,
+        "main-es2015": 446749,
         "polyfills-es2015": 52493
       }
     }
diff --git a/goldens/size-tracking/integration-payloads.json b/goldens/size-tracking/integration-payloads.json
@@ -3,7 +3,7 @@
     "master": {
       "uncompressed": {
         "runtime-es2015": 1485,
-        "main-es2015": 140899,
+        "main-es2015": 134899,
         "polyfills-es2015": 36571
       }
     }
diff --git a/packages/core/src/application_ref.ts b/packages/core/src/application_ref.ts
@@ -573,7 +573,6 @@ export class ApplicationRef {
   private _bootstrapListeners: ((compRef: ComponentRef<any>) => void)[] = [];
   private _views: InternalViewRef[] = [];
   private _runningTick: boolean = false;
-  private _enforceNoNewChanges: boolean = false;
   private _stable = true;
   private _onMicrotaskEmptySubscription: Subscription;
 
@@ -602,8 +601,6 @@ export class ApplicationRef {
       private _exceptionHandler: ErrorHandler,
       private _componentFactoryResolver: ComponentFactoryResolver,
       private _initStatus: ApplicationInitStatus) {
-    this._enforceNoNewChanges = isDevMode();
-
     this._onMicrotaskEmptySubscription = this._zone.onMicrotaskEmpty.subscribe({
       next: () => {
         this._zone.run(() => {
@@ -740,7 +737,9 @@ export class ApplicationRef {
       for (let view of this._views) {
         view.detectChanges();
       }
-      if (this._enforceNoNewChanges) {
+      // Note that we have still left the `isDevMode()` condition in order to avoid
+      // creating a breaking change for projects that still use the View Engine.
+      if ((typeof ngDevMode === 'undefined' || ngDevMode) && isDevMode()) {
         for (let view of this._views) {
           view.checkNoChanges();
         }

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`"master": {`
`13`	`13`	`"uncompressed": {`
`14`	`14`	`"runtime-es2015": 3033,`
`15`		`- "main-es2015": 447343,`
	`15`	`+ "main-es2015": 446749,`
`16`	`16`	`"polyfills-es2015": 52493`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`"master": {`
`4`	`4`	`"uncompressed": {`
`5`	`5`	`"runtime-es2015": 1485,`
`6`		`- "main-es2015": 140899,`
	`6`	`+ "main-es2015": 134899,`
`7`	`7`	`"polyfills-es2015": 36571`
`8`	`8`	`}`
`9`	`9`	`}`