build: remove irrelevant madge circular deps tests (#61156) · angular/angular@032b802 · GitHub
Skip to content

Commit 032b802

Browse files
devversionAndrewKushnir
devversion
authored and
AndrewKushnir
committed
build: remove irrelevant madge circular deps tests (#61156)
We don't need this tooling anymore because we are already validating that there are no circular dependencies via the `ng-dev` tooling that checks `.ts` files directly. Also these tests never actually failed to my knowledge. PR Close #61156
1 parent 516fdcc commit 032b802

34 files changed

Lines changed: 20 additions & 1234 deletions

File tree

‎.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx‎

Lines changed: 3 additions & 3 deletions

‎.pullapprove.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,6 @@ groups:
336336
'scripts/**/{*,.*}',
337337
'third_party/**/{*,.*}',
338338
'tools/bazel-repo-patches/**/{*,.*}',
339-
'tools/circular_dependency_test/**/{*,.*}',
340339
'tools/contributing-stats/**/{*,.*}',
341340
'tools/esm-interop/**/{*,.*}',
342341
'tools/gulp-tasks/**/{*,.*}',

‎package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@
212212
"karma-jasmine-html-reporter": "^2.1.0",
213213
"karma-sauce-launcher": "^4.3.6",
214214
"live-server": "^1.2.2",
215-
"madge": "^8.0.0",
216215
"marked": "^15.0.0",
217216
"mermaid": "^11.0.0",
218217
"patch-package": "^7.0.0",

‎packages/animations/browser/test/BUILD.bazel‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,4 @@
11
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
2-
load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
3-
4-
circular_dependency_test(
5-
name = "circular_deps_test",
6-
entry_point = "angular/packages/animations/browser/index.mjs",
7-
deps = ["//packages/animations/browser"],
8-
)
9-
10-
circular_dependency_test(
11-
name = "testing_circular_deps_test",
12-
entry_point = "angular/packages/animations/browser/testing/index.mjs",
13-
deps = ["//packages/animations/browser/testing"],
14-
)
152

163
ts_library(
174
name = "test_lib",

‎packages/animations/test/BUILD.bazel‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,4 @@
11
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
2-
load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
3-
4-
circular_dependency_test(
5-
name = "circular_deps_test",
6-
entry_point = "angular/packages/animations/index.mjs",
7-
deps = [
8-
"//packages/animations",
9-
],
10-
)
112

123
ts_library(
134
name = "test_lib",

‎packages/common/http/test/BUILD.bazel‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
11
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
2-
load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
3-
4-
circular_dependency_test(
5-
name = "circular_deps_test",
6-
entry_point = "angular/packages/common/http/index.mjs",
7-
deps = ["//packages/common/http"],
8-
)
92

103
ts_library(
114
name = "test_lib",

‎packages/common/http/testing/test/BUILD.bazel‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
11
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
2-
load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
3-
4-
circular_dependency_test(
5-
name = "circular_deps_test",
6-
entry_point = "angular/packages/common/http/testing/index.mjs",
7-
deps = ["//packages/common/http/testing"],
8-
)
92

103
ts_library(
114
name = "test_lib",

‎packages/common/test/BUILD.bazel‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,4 @@
11
load("//tools:defaults.bzl", "jasmine_node_test", "karma_web_test_suite", "ts_library")
2-
load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
3-
4-
circular_dependency_test(
5-
name = "circular_deps_test",
6-
entry_point = "angular/packages/common/index.mjs",
7-
deps = ["//packages/common"],
8-
)
9-
10-
circular_dependency_test(
11-
name = "testing_circular_deps_test",
12-
entry_point = "angular/packages/common/testing/index.mjs",
13-
deps = ["//packages/common/testing"],
14-
)
152

163
ts_library(
174
name = "test_lib",

‎packages/common/upgrade/test/BUILD.bazel‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,4 @@
11
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
2-
load("//tools/circular_dependency_test:index.bzl", "circular_dependency_test")
3-
4-
circular_dependency_test(
5-
name = "circular_deps_test",
6-
entry_point = "angular/packages/common/upgrade/index.mjs",
7-
deps = ["//packages/common/upgrade"],
8-
)
92

103
ts_library(
114
name = "test_lib",

‎packages/compiler/test/BUILD.bazel‎

Lines changed: 0 additions & 7 deletions

0 commit comments

Comments
 (0)