CustomTitle annotation added by Bersh · Pull Request #376 · androidannotations/androidannotations · GitHub
Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

CustomTitle annotation added#376

Merged
pyricau merged 7 commits into
androidannotations:developfrom
Bersh:customTitle
Feb 28, 2013
Merged

CustomTitle annotation added#376
pyricau merged 7 commits into
androidannotations:developfrom
Bersh:customTitle

Conversation

@Bersh

@Bersh Bersh commented Nov 4, 2012

Copy link
Copy Markdown

Hi!
This is my first pull request so excuse if something wrong.

I've add CustomTitle annotation which allows to specify custom title layout for activity

@pyricau

pyricau commented Nov 4, 2012

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have no relation with the subject of the pull request and doesn't match our coding standards (no wildcard imports).

@Bersh

Bersh commented Nov 4, 2012

Copy link
Copy Markdown
Author

Thanks for your comments! I'll try to fix it when I'll have free time

@pyricau

pyricau commented Nov 7, 2012

Copy link
Copy Markdown
Contributor

Ok :) . You'll also notice that we just changed all the packages from com.googlecode.androidannotations to org.androidannotations. You'll need to merge from develop to get those changes. You may have a few conflicts, but hopefully nothing too hard to fix.

@Bersh

Bersh commented Nov 19, 2012

Copy link
Copy Markdown
Author

At last I managed to fix my changes. I've had some problems with merging, but everything should be fine now. Unfortunately, because of this problems I can see some unneeded commits as added. I've no idea how i can fix it, so excuse me for adding unnecessary commits. My last changes should contains only 17937a0 and 35b94f4 commits

@pyricau

pyricau commented Nov 19, 2012

Copy link
Copy Markdown
Contributor

Well, if you don't know how to clean a Git history, then better not do it and keep it this way ;) . I'll have a look and merge when I have more time (maybe on thursday).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use it on activities to set a custom layout

@pyricau

pyricau commented Nov 22, 2012

Copy link
Copy Markdown
Contributor

Other then these two comments, this looks nice. Once you're done, I'll checkout the code, check that everything works fine, and then merge.

@ghost ghost assigned mathieuboniface Jan 29, 2013
@ghost ghost assigned pyricau Feb 28, 2013
pyricau added a commit that referenced this pull request Feb 28, 2013
@pyricau pyricau merged commit f61c956 into androidannotations:develop Feb 28, 2013
@pyricau

pyricau commented Feb 28, 2013

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants