Activity

1. pyricau commented on Jun 28, 2012

   

   pyricau

   on Jun 28, 2012

   Contributor

   More actions

   I think that's a quite valid use case. @a-thomas what do you think ?
2. pyricau commented on Jun 28, 2012

   

   pyricau

   on Jun 28, 2012

   Contributor

   More actions

   For @Accept, we can either :

   • Replace the MediaType enum with a class holding String constants, and update @Accept to take a String value() param
   • Keep the current value() parameter that can have a default empty value, and add a new stringType() (we need to find a better name) that accepts Strings.

   I think the first option would be more universal. And it should be retrocompatible, if we keep the same qualified name for MediaType.

   In the generated code, instead of:

   httpHeaders.setAccept(Collections.singletonList(MediaType.APPLICATION_JSON));

   We would do:

   httpHeaders.setAccept(Collections.singletonList(MediaType.parseMediaType("text/json")));
3. pyricau commented on Jun 28, 2012

   

   pyricau

   on Jun 28, 2012

   Contributor

   More actions

   And by the way, @a-thomas , why did we create our own MediaType enum instead of using org.springframework.http.MediaType ?
4. a-thomas commented on Jul 3, 2012

   

   a-thomas

   on Jul 3, 2012

   Contributor

   More actions

   I think I did that because Spring dependencies are not available in androidannotations project. So, I have created our own MediaType to use the "native" annotation validation.

   See:

   @Retention(RetentionPolicy.SOURCE)
   @Target({ ElementType.METHOD, ElementType.TYPE })
   public @interface Accept {
       MediaType value();
   }
5. a-thomas commented on Jul 3, 2012

   

   a-thomas

   on Jul 3, 2012

   Contributor

   More actions

   Replace the MediaType enum with a class holding String constants, and update @accept to take a String value() param

   I totally agree with you. I create an issue.
6. pyricau commented on Jul 3, 2012

   

   pyricau

   on Jul 3, 2012

   Contributor

   More actions

   You're right :) .
7. pyricau

   added a commit that references this issue on Aug 2, 2012

   Merge pull request #261 from excilys/260_Replace_@Accept_MediaType

   ...

   cd09c11
8. pyricau commented on Aug 2, 2012

   

   pyricau

   on Aug 2, 2012

   Contributor

   More actions

   Fixed by cd09c11
9. pyricau

   closed this as completedon Aug 2, 2012