{{ message }}
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
WIP Plugin system#1480
Merged
Merged
Conversation
70981a1 to
e528406
Compare
Contributor
Author
Member
|
What about this? |
Contributor
Author
|
Your proposition makes sense. |
This commit remove the need to invalidate the IsValid instance and to print the error. All is done with on method.
We don't copy api classes anymore since it can break projects with libraries using AA.
We decided to no longer generate and release bundles, since most developers now use much more convenient dependency management.
We no longer generate API classes, because all API classes are statically compiled into the API jar. So these tests are obsolete.
Also remove no longer used methods.
Some test Activities were removed.
Contributor
|
Do you guys have a mvn snapshot repo (maybe via github) for this PR, so interested folks could help testing? |
Member
|
as far as i know no, but you can checkout https://github.com/yDelouis/androidannotations/tree/957_plugins and run |
Member
|
@dodgex is right, we do not have a repo, but interested folks can really simple build the lib itself. I really hope this will be merged into develop soon, after that you can try in the conventional OSS snapshot repo. |
4271ed6 to
8c03ad3
Compare
8c03ad3 to
680a18b
Compare
680a18b to
a66bf87
Compare
b74425f to
0a8cf13
Compare
Member
|
Nice! Finally merged. :D |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is not ready at all and is created only to show the work in progress so that people can comment.