{{ message }}
Spell success properly#1254
Merged
Merged
Conversation
Contributor
|
hi @greg0ire, thanks a lot for this PR, but as you guessed it, this would be a breaking change for those who write a custom requester today. It would be possible to alias it to the correct name, and accept both wrong and correct spelling, or to add a comment |
Author
Is there a standard way in JS to trigger a deprecation when a call is performed with the wrong spelling? |
Contributor
greg0ire
force-pushed
the
spell-success-properly
branch
from
2df16ea to
07dcc12
Compare
Haroenv
approved these changes
Mar 2, 2021
This was referenced Mar 10, 2021
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning: I'm not a JS developer so I have no idea if there might be BC-breaks in this PR or not. I also don't know if this might actually fix any bug, hence why I picked
refactorhere.