Change Show/Hide labeling for improved clarity · Issue #798 · ableplayer/ableplayer · GitHub
Skip to content

Change Show/Hide labeling for improved clarity #798

Open

Description

@joedolson

Describe the bug
Able Player uses a combination of aria-pressed and label text which is a pet peeve of mine, because the control name changes based on state. This creates a screen reader experience that reports that a button is pressed, with text "Show Captions" and a button that is not pressed with text saying "Hide Captions"; this makes it unclear what the button will actually do.

This currently applies to the captions button when there's only one set of captions, the Show Transcript button, the Audio Description button, and the Fullscreen button,

There are a few other inconsistencies in usage of aria attributes here, but those can still be done in 5.1; I'm going to defer text changes to 5.2, however, as it's too late for translation changes.

Version tested
Which version of AblePlayer are you reporting against?

  • Develop (the next release)

Activity

  1. added this to the 5.2 milestone on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions