Improve SSE implementation

A review on #820 showed that our SSE implementation might be too naive:

The current SSE implementation incorrectly dispatches each line starting with data: as a separate message. According to the SSE specification, multiple data: lines should be buffered and concatenated (with newlines) until an empty line is encountered, at which point the complete event should be dispatched. This will cause JSON parsing failures for any multi-line payloads.

FWIW https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events/Using_server-sent_events#event_stream_format to correctly implement the SSE format.

It could be interesting to also add event to our stream (eg: event: <message|task| statusUpdate|artifactUpdate)

We could try to reuse the implementation I wrote for vertx

@jmesnil

@jmesnil does that means that we wouldn't rely on the data events only anymore ?

@ehsavoie

@ehsavoie no, the idea was to identify the data with an event something like:

event: statusUpdate
data: {"statusUpdate": {"taskId": "task-uuid", "status": {"state": "TASK_STATE_COMPLETED"}}}

but this is silly, the type of events is already clear from the data.

Well it could 'help' if you want to subscribe to only a single source/type of event but then you would need to register to every type

feat(http-client): introduce ServerSentEvent type and spec-compliant …

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Improve SSE implementation #839

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Sunbelt Computer Software

PL/B Language Development and Support

Improve SSE implementation #839

Description

Activity

jmesnil commented on Apr 29, 2026

ehsavoie commented on Apr 29, 2026

ehsavoie commented on Apr 30, 2026

jmesnil commented on Apr 30, 2026

ehsavoie commented on Apr 30, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions