build: update build scripts to no longer build View Engine output (#4… · Usefull-Repository/angular@fcd958d · GitHub
Skip to content

Commit fcd958d

Browse files
devversiondylhunn
devversion
authored and
dylhunn
committed
build: update build scripts to no longer build View Engine output (angular#43431)
Removes View Engine compilation from the package builder script. For v13, we can no longer ship View Engine packages. PR Close angular#43431
1 parent 7cba3f3 commit fcd958d

6 files changed

Lines changed: 6 additions & 72 deletions

File tree

‎.circleci/config.yml‎

Lines changed: 1 addition & 24 deletions

‎scripts/build/angular-in-memory-web-api.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function buildAngularInMemoryWebApiPackage(destDir) {
3434
console.info(`${scriptPath}:`);
3535
console.info(' Building angular-in-memory-web-api npm package');
3636
console.info('##############################');
37-
exec(`${bazelCmd} build //packages/misc/angular-in-memory-web-api:npm_package`);
37+
exec(`${bazelCmd} build //packages/misc/angular-in-memory-web-api:npm_package --config=ivy`);
3838

3939
// Create the output directory.
4040
const absDestDir = resolve(baseDir, destDir);

‎scripts/build/build-ivy-npm-packages.js‎

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎scripts/build/build-packages-dist.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const {buildZoneJsPackage} = require('./zone-js-builder');
1515

1616

1717
// Build the legacy (view engine) npm packages into `dist/packages-dist/`.
18-
buildTargetPackages('dist/packages-dist', false, 'Production');
18+
buildTargetPackages('dist/packages-dist', 'Production');
1919

2020
// Build the `angular-in-memory-web-api` npm package into `dist/angular-in-memory-web-api-dist/`,
2121
// because it might be needed by other scripts/targets.

‎scripts/build/package-builder.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,11 @@ module.exports = {
6060
*
6161
* @param {string} destDir Path to the output directory into which we copy the npm packages.
6262
* This path should either be absolute or relative to the project root.
63-
* @param {boolean} enableIvy True, if Ivy should be used.
6463
* @param {string} description Human-readable description of the build.
6564
* @param {boolean?} isRelease True, if the build should be stamped for a release.
6665
* @returns {Array<{name: string, outputPath: string}} A list of packages built.
6766
*/
68-
function buildTargetPackages(destDir, enableIvy, description, isRelease = false) {
67+
function buildTargetPackages(destDir, description, isRelease = false) {
6968
console.info('##################################');
7069
console.info(`${scriptPath}:`);
7170
console.info(' Building @angular/* npm packages');
@@ -93,8 +92,8 @@ function buildTargetPackages(destDir, enableIvy, description, isRelease = false)
9392

9493
// Use either `--config=snapshot` or `--config=release` so that builds are created with the
9594
// correct embedded version info.
96-
exec(`${bazelCmd} build --config=${isRelease ? 'release' : 'snapshot'} --config=${
97-
enableIvy ? 'ivy' : 'view-engine'} ${targets.join(' ')}`);
95+
exec(`${bazelCmd} build --config=${isRelease ? 'release' : 'snapshot'} --config=ivy ${
96+
targets.join(' ')}`);
9897

9998
// Create the output directory.
10099
const absDestDir = resolve(baseDir, destDir);

‎scripts/ci/publish-build-artifacts.sh‎

Lines changed: 0 additions & 5 deletions

0 commit comments

Comments
 (0)