[mypy] Fix type annotations for strings (#4641) · UnixJunkie/all-algorithms-python@5e7eed6 · GitHub
Skip to content

Commit 5e7eed6

Browse files
authored
[mypy] Fix type annotations for strings (TheAlgorithms#4641)
* Fix mypy error for min_cost_string_conversion.py * Fix mypy error for manacher.py * Fix mypy error for aho_corasick.py
1 parent 78a5d3a commit 5e7eed6

3 files changed

Lines changed: 29 additions & 26 deletions

File tree

strings/aho_corasick.py

Lines changed: 13 additions & 9 deletions

strings/manacher.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,27 +35,28 @@ def palindromic_string(input_string: str) -> str:
3535
length = [1 for i in range(len(new_input_string))]
3636

3737
# for each character in new_string find corresponding palindromic string
38-
for i in range(len(new_input_string)):
39-
k = 1 if i > r else min(length[l + r - i] // 2, r - i + 1)
38+
start = 0
39+
for j in range(len(new_input_string)):
40+
k = 1 if j > r else min(length[l + r - j] // 2, r - j + 1)
4041
while (
41-
i - k >= 0
42-
and i + k < len(new_input_string)
43-
and new_input_string[k + i] == new_input_string[i - k]
42+
j - k >= 0
43+
and j + k < len(new_input_string)
44+
and new_input_string[k + j] == new_input_string[j - k]
4445
):
4546
k += 1
4647

47-
length[i] = 2 * k - 1
48+
length[j] = 2 * k - 1
4849

4950
# does this string is ending after the previously explored end (that is r) ?
5051
# if yes the update the new r to the last index of this
51-
if i + k - 1 > r:
52-
l = i - k + 1 # noqa: E741
53-
r = i + k - 1
52+
if j + k - 1 > r:
53+
l = j - k + 1 # noqa: E741
54+
r = j + k - 1
5455

5556
# update max_length and start position
56-
if max_length < length[i]:
57-
max_length = length[i]
58-
start = i
57+
if max_length < length[j]:
58+
max_length = length[j]
59+
start = j
5960

6061
# create that string
6162
s = new_input_string[start - max_length // 2 : start + max_length // 2 + 1]

strings/min_cost_string_conversion.py

Lines changed: 3 additions & 5 deletions

0 commit comments

Comments
 (0)