{{ message }}
Repository navigation
fix: MultiReturn unpacking with get accessors is broken #1542
Description
Introduction / Explenation
Upon running the example below, you'll quickly realize that the getter function errors, whereas the normal function does not.
Even though they consist of the same code.
The issue seems to be with unwrapping return values in class getters.
What should happen instead?
I think most of us would simply expect both these code snippets to work the exact same, aka to unwrap the return values without any issues.
Reproduction
Code
class TestClass {
public get Test1(): LuaMultiReturn<[number, number]>{
return $multi(0, 0);
}
public Test2(): LuaMultiReturn<[number, number]>{
return $multi(0, 0);
}
public showcaseIssue(): void {
const [a, b] = this.Test2();
console.log(a,b)
const [c, d] = this.Test1;
console.log(c,d)
}
}
const a = new TestClass();
a.showcaseIssue()
Activity
[-]fix: retval unpacking in class getters are broken[/-][+]fix: MultiReturn unpacking with get accessors are broken[/+][-]fix: MultiReturn unpacking with get accessors are broken[/-][+]fix: MultiReturn unpacking with get accessors is broken[/+]Gudine commentedon Oct 24, 2024
I'm pretty sure the syntax
local c, d = table.unpack(self.Test1)can't work at all in Lua, since multiple returns can only come out of functions, andself.Test1is a parameter, so it can only give you one value.Here's how it'd work in pure Lua:
The only solution would be to make getters actually call the function, but I think that would remove any benefit of using a getter in the first place.