Activity

1. Perryvw

   added

   enhancement

   scope: transformationTransformation of TS to LuaTransformation of TS to Lua

   on Aug 31, 2023
2. lolleko commented on Sep 10, 2023

   

   lolleko

   on Sep 10, 2023

   Member

   More actions

   Unfortunately, it is not as simple as replacing pcall with xpcall & debug.traceback.
   Because using xpcall & debug.traceback will break our throw implementation.

   e.g.

         try {
             throw "Hello, I am an Error!";
         } catch (error) {
             return error;
         }
   

   would return:

   Hello, I am an Error!
       stack traceback:
           [C]: in function 'error'
           [string \"...\"]:17: in function <[string \"...\"]:16>
           [C]: in function 'xpcall'
           [string \"...\"]:15: in function <[string \"...\"]:6>
           (...tail calls...)
           [string \"...\"]:3: in main chunk
   

   instead of the correct/JS behavior

   Hello, I am an Error!
   

   This can possibly be solved by changing the way we throw string literals. Another solution might be to create a custom/adapted implementation of debug.tracepack.
3. BribeFromTheHive commented on Feb 9, 2024

   

   BribeFromTheHive

   on Feb 9, 2024

   More actions

   Likely the best middle ground is that an empty catch block can compile to an xpcall, and a non-empty one can compile as-is. Same with un-caught rejected promise objects, if they don't already work that way.
4. pilaoda commented on Mar 27, 2024

   

   pilaoda

   on Mar 27, 2024

   ContributorAuthor

   More actions

   TypeScriptToLua/src/lualib/Await.ts

   Lines 55 to 58 in 16a8eb3

   	const [success, resultOrError] = coresume(asyncCoroutine, (v: unknown) => {
   	resolved = true;
   	return __TS__Promise.resolve(v).addCallbacks(resolve, reject);
   	});

   
   coroutine.resume also lack of stack trace, the asyncCoroutine should pass into debug.traceback as the first argument to get the error trace in coroutine context.
5. fadabaerobe6 commented on Apr 27, 2024

   

   fadabaerobe6

   on Apr 27, 2024

   Last edited by fadabaerobe6

   More actions

   -- Reimplemented pcall function
   _G.pcall = function(func, ...)
       local results = table.pack(
           xpcall(func, function(err)
               -- Do nothing here, just return the error object
               return err..'\n'..debug.traceback()
           end, ...)
       )
       local status = table.remove(results, 1)
       if not status then
           -- When an error occurs, err is the error message, mimicking the behavior of pcall
           return false, table.unpack(results)
       else
           -- No error occurred, return all the additional parameters returned by xpcall
           return true, table.unpack(results)
       end
   end

   We can use xpcall to override pcall method to find the origin trackback