try/finally does not behave as expected when rethrowing

See re-throw test in test/unit/error.spec.ts:

const i: number = ${i};
function foo() {
    try {
        try {
            if (i === 0) { throw "z"; }
        } catch (e) {
            throw "a";
        } finally {
            if (i === 1) { throw "b"; }
        }
    } catch (e) {
        throw (e as string).toUpperCase();
    } finally {
        throw "C";
    }
}
let result: string = "x";
try {
    foo();
} catch (e) {
    result = (e as string)[(e as string).length - 1];
}
return result;

Just to clarify and simplify.
The issue is that the Finally block is not getting called.

This TypeScript code when compiled with `tsc`:

try {
    try {
        throw 'the error'
    } catch (err) {
        console.log('Catch Block')
        throw 'rethrow'
    } finally {
        console.log('Finally Block')
    }
} catch (err) {
    console.log(`Outer Catch`)
}

Produces this output:

Catch Block
Finally Block
Outer Catch

The equivalent code in TSTL

try {
        try {
            error('the error')
        } catch (err) {
            Echo('Catch Block')
            error(`rethrown`)
        } finally {
            Echo('Finally Block')
        }
    } catch (err) {
        Echo(`Outer Catch`)
}

Produces this output:

Catch Block
Outer Catch

The finally block is NOT called 😞

~~bump~~

~~throw not working in the try block when finally is presented.~~

try
{
    print(1);
    throw new Error("123");
}
finally
{
    print(2);
}

print(3);

Above code smoothly gives me

1
2
3

@thautwarm

@thautwarm The above code you show seems to be doing what is expected.
The problem starts when you re-throw an error in the catch block.

try {
        try {
            error('the error')
        } catch (err) {
            Echo('Catch Block')
            error(`rethrown`)
        } finally {
            Echo('Finally Block')
        }
    } catch (err) {
        Echo(`Outer Catch`)
}

The output is:

Catch Block
Outer Catch

The finally block is not called 😞

I apologize for this. I didn't recognize this issue is not related to my question.

Fix try/catch/finally flow (#1729)

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

try/finally does not behave as expected when rethrowing #1137

This TypeScript code when compiled with `tsc`:

The equivalent code in TSTL

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Sunbelt Computer Software

PL/B Language Development and Support

try/finally does not behave as expected when rethrowing #1137

Description

Activity

hepiyellow commented on Jun 7, 2023

This TypeScript code when compiled with tsc:

The equivalent code in TSTL

thautwarm commented on Sep 14, 2023

thautwarm commented on Sep 14, 2023

thautwarm commented on Sep 14, 2023

hepiyellow commented on Sep 14, 2023

thautwarm commented on Sep 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

This TypeScript code when compiled with `tsc`: