Comparing master...debug/type-alias · Teamwork/kommentaar · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Teamwork/kommentaar
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Teamwork/kommentaar
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: debug/type-alias
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Jun 25, 2024

  1. Debug: Test case scenario where definition is missing 

    Attempt to figure out why the definition is missing on a specific scenario:

```
$ go test -run TestOpenAPI2/typealias
--- FAIL: TestOpenAPI2 (0.03s)
    --- FAIL: TestOpenAPI2/typealias (0.03s)
        main_test.go:86: incorrect output:
            swagger: "2.0"
            info:
              title: x
              version: x
            consumes:
              - application/json
            produces:
              - application/json
            paths:
              /path:
                post:
                  operationId: POST_path
                  consumes:
                    - application/json
                  produces:
                    - application/json
                  parameters:
                    - name: typealias.ReqRef
                      in: body
                      required: true
                      schema:
                        $ref: '#/definitions/typealias.ReqRef'
                  responses:
                    200:
                      description: 200 OK (no data)
            definitions:
              typealias.ReqRef:
                title: ReqRef
                description: ReqRef is a request reference.
                type: object
                properties:
                  anonymous:
                    type: object
                    properties:
                      alias:
                        type: object
                        additionalProperties:
                          $ref: '#/definitions/typealias.ExampleItem'
        main_test.go:87: diff

            --- expected
            +++ actual
            @@ -37,13 +37,3 @@
                         additionalProperties:
                           $ref: '#/definitions/typealias.ExampleItem'
            -  typealias.ExampleItem:
            -    title: ExampleItem
            -    description: ExampleItem is an example item.
            -    type: object
            -    properties:
            -      properties:
            -        field1:
            -          type: string
            -        field2:
            -          type: integer

FAIL
exit status 1
FAIL	github.com/teamwork/kommentaar	1.220s
```
    @rafaeljusto
    rafaeljusto committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2ff59d6 View commit details
    Browse the repository at this point in the history
Loading