test(react-virtual): wait for reconcile to retire the scroll, not for… · TanStack/virtual@b1db2c0 · GitHub
Skip to content

Commit b1db2c0

Browse files
piecykclaude
andcommitted
test(react-virtual): wait for reconcile to retire the scroll, not for equal samples
Review follow-up. Two scrollTop samples 100ms apart can straddle the pause between two reconcileScroll re-drives, so equal samples do not prove the smooth scroll has completed. The virtualizer has the real signal: reconcileScroll retires `scrollState` only once the target is stable and reached. Expose the instance on the fixture page and wait for `scrollState === null && !isScrolling` after the target row is visible, keeping the 15s ceiling. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 parent 10f169e commit b1db2c0

2 files changed

Lines changed: 16 additions & 14 deletions

File tree

‎packages/react-virtual/e2e/app/smooth-scroll/main.tsx‎

Lines changed: 4 additions & 0 deletions

‎packages/react-virtual/e2e/app/test/smooth-scroll.spec.ts‎

Lines changed: 12 additions & 14 deletions

0 commit comments

Comments
 (0)