chore(oxlint.config): enable 'vitest/prefer-mock-promise-shorthand' a… · TanStack/query@5393cdc · GitHub
Skip to content

Commit 5393cdc

Browse files
sukvvonsukvvon
authored
chore(oxlint.config): enable 'vitest/prefer-mock-promise-shorthand' and use 'mockResolvedValue' and 'mockRejectedValue' (#12242)
1 parent 3afe752 commit 5393cdc

8 files changed

Lines changed: 16 additions & 43 deletions

File tree

‎oxlint.config.ts‎

Lines changed: 1 addition & 0 deletions

‎packages/preact-query/src/__tests__/useMutation.test.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -465,9 +465,7 @@ describe('useMutation', () => {
465465

466466
const mutateFn = vi.fn<(value: Value) => Promise<Value>>()
467467

468-
mutateFn.mockImplementationOnce(() => {
469-
return Promise.reject(new Error('Error test Jonas'))
470-
})
468+
mutateFn.mockRejectedValueOnce(new Error('Error test Jonas'))
471469

472470
mutateFn.mockImplementation((value) =>
473471
sleep(10).then(() => Promise.resolve(value)),

‎packages/preact-query/src/__tests__/useQuery.test.tsx‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3268,9 +3268,7 @@ describe('useQuery', () => {
32683268
const key = queryKey()
32693269

32703270
const queryFn = vi.fn<(...args: Array<unknown>) => unknown>()
3271-
queryFn.mockImplementation(() => {
3272-
return Promise.reject(new Error('Error test Barrett'))
3273-
})
3271+
queryFn.mockRejectedValue(new Error('Error test Barrett'))
32743272

32753273
function Page() {
32763274
const { status, failureCount, failureReason } = useQuery({
@@ -3307,13 +3305,9 @@ describe('useQuery', () => {
33073305

33083306
const queryFn = vi.fn<(...args: Array<unknown>) => unknown>()
33093307

3310-
queryFn.mockImplementationOnce(() => {
3311-
return Promise.reject(new Error('Error test Tanner'))
3312-
})
3308+
queryFn.mockRejectedValueOnce(new Error('Error test Tanner'))
33133309

3314-
queryFn.mockImplementation(() => {
3315-
return Promise.reject(new Error('NoRetry'))
3316-
})
3310+
queryFn.mockRejectedValue(new Error('NoRetry'))
33173311

33183312
function Page() {
33193313
const { status, failureCount, failureReason, error } = useQuery({
@@ -3353,9 +3347,7 @@ describe('useQuery', () => {
33533347
type DelayError = { delay: number }
33543348

33553349
const queryFn = vi.fn<(...args: Array<unknown>) => unknown>()
3356-
queryFn.mockImplementation(() => {
3357-
return Promise.reject({ delay: 50 })
3358-
})
3350+
queryFn.mockRejectedValue({ delay: 50 })
33593351

33603352
function Page() {
33613353
const { status, failureCount, failureReason } = useQuery({

‎packages/query-core/src/__tests__/hydration.test.tsx‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -576,9 +576,7 @@ describe('dehydration and rehydration', () => {
576576
consoleErrorMock.mockImplementation(() => undefined)
577577
const onlineMock = mockOnlineManagerIsOnline(false)
578578

579-
const serverAddTodo = vi
580-
.fn()
581-
.mockImplementation(() => Promise.reject(new Error('offline')))
579+
const serverAddTodo = vi.fn().mockRejectedValue(new Error('offline'))
582580
const serverOnMutate = vi
583581
.fn()
584582
.mockImplementation((variables: { text: string }) => {
@@ -662,9 +660,7 @@ describe('dehydration and rehydration', () => {
662660
const consoleErrorMock = vi.spyOn(console, 'error')
663661
consoleErrorMock.mockImplementation(() => undefined)
664662

665-
const serverAddTodo = vi
666-
.fn()
667-
.mockImplementation(() => Promise.reject(new Error('offline')))
663+
const serverAddTodo = vi.fn().mockRejectedValue(new Error('offline'))
668664

669665
const queryClient = new QueryClient()
670666

@@ -696,9 +692,7 @@ describe('dehydration and rehydration', () => {
696692
const consoleErrorMock = vi.spyOn(console, 'error')
697693
consoleErrorMock.mockImplementation(() => undefined)
698694

699-
const serverAddTodo = vi
700-
.fn()
701-
.mockImplementation(() => Promise.reject(new Error('offline')))
695+
const serverAddTodo = vi.fn().mockRejectedValue(new Error('offline'))
702696

703697
const queryClient = new QueryClient()
704698

‎packages/query-core/src/__tests__/queryClient.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ describe('queryClient', () => {
535535

536536
it('should not fetch with initialData', async () => {
537537
const key = queryKey()
538-
const queryFn = vi.fn().mockImplementation(() => Promise.resolve('data'))
538+
const queryFn = vi.fn().mockResolvedValue('data')
539539

540540
await expect(
541541
// oxlint-disable-next-line tanstack-query/no-restricted-syntax -- grandfathered direct test

‎packages/react-query/src/__tests__/useMutation.test.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -464,9 +464,7 @@ describe('useMutation', () => {
464464

465465
const mutateFn = vi.fn<(value: Value) => Promise<Value>>()
466466

467-
mutateFn.mockImplementationOnce(() => {
468-
return Promise.reject(new Error('Error test Jonas'))
469-
})
467+
mutateFn.mockRejectedValueOnce(new Error('Error test Jonas'))
470468

471469
mutateFn.mockImplementation((value) =>
472470
sleep(10).then(() => Promise.resolve(value)),

‎packages/react-query/src/__tests__/useQuery.test.tsx‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3256,9 +3256,7 @@ describe('useQuery', () => {
32563256
const key = queryKey()
32573257

32583258
const queryFn = vi.fn<(...args: Array<unknown>) => unknown>()
3259-
queryFn.mockImplementation(() => {
3260-
return Promise.reject(new Error('Error test Barrett'))
3261-
})
3259+
queryFn.mockRejectedValue(new Error('Error test Barrett'))
32623260

32633261
function Page() {
32643262
const { status, failureCount, failureReason } = useQuery({
@@ -3295,13 +3293,9 @@ describe('useQuery', () => {
32953293

32963294
const queryFn = vi.fn<(...args: Array<unknown>) => unknown>()
32973295

3298-
queryFn.mockImplementationOnce(() => {
3299-
return Promise.reject(new Error('Error test Tanner'))
3300-
})
3296+
queryFn.mockRejectedValueOnce(new Error('Error test Tanner'))
33013297

3302-
queryFn.mockImplementation(() => {
3303-
return Promise.reject(new Error('NoRetry'))
3304-
})
3298+
queryFn.mockRejectedValue(new Error('NoRetry'))
33053299

33063300
function Page() {
33073301
const { status, failureCount, failureReason, error } = useQuery({
@@ -3341,9 +3335,7 @@ describe('useQuery', () => {
33413335
type DelayError = { delay: number }
33423336

33433337
const queryFn = vi.fn<(...args: Array<unknown>) => unknown>()
3344-
queryFn.mockImplementation(() => {
3345-
return Promise.reject({ delay: 50 })
3346-
})
3338+
queryFn.mockRejectedValue({ delay: 50 })
33473339

33483340
function Page() {
33493341
const { status, failureCount, failureReason } = useQuery({

‎packages/solid-query/src/__tests__/useMutation.test.tsx‎

Lines changed: 1 addition & 3 deletions

0 commit comments

Comments
 (0)