Ensure spot v3 version (#1587) · SoniCoder/python-binance@5ee540e · GitHub
Skip to content

Commit 5ee540e

Browse files
authored
Ensure spot v3 version (sammchardy#1587)
* add timeout to jobs * feat: assure v3 is used * lint * lint * remove change * fix test * Revert "lint" This reverts commit a3c46d1. * revert lint * Revert "revert lint" This reverts commit 81bd534.
1 parent 52877c0 commit 5ee540e

5 files changed

Lines changed: 84 additions & 48 deletions

File tree

binance/async_client.py

Lines changed: 15 additions & 15 deletions

binance/base_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class BaseClient:
3939
WS_API_TESTNET_URL = "wss://ws-api.testnet.binance.vision/ws-api/v3"
4040
WS_FUTURES_URL = "wss://ws-fapi.binance.{}/ws-fapi/v1"
4141
WS_FUTURES_TESTNET_URL = "wss://testnet.binancefuture.com/ws-fapi/v1"
42-
PUBLIC_API_VERSION = "v1"
42+
PUBLIC_API_VERSION = "v3"
4343
PRIVATE_API_VERSION = "v3"
4444
MARGIN_API_VERSION = "v1"
4545
MARGIN_API_VERSION2 = "v2"

binance/client.py

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def get_exchange_info(self) -> Dict:
274274

275275
"""
276276

277-
return self._get("exchangeInfo", version=self.PRIVATE_API_VERSION)
277+
return self._get("exchangeInfo")
278278

279279
def get_symbol_info(self, symbol) -> Optional[Dict]:
280280
"""Return information about a symbol
@@ -341,7 +341,7 @@ def ping(self) -> Dict:
341341
:raises: BinanceRequestException, BinanceAPIException
342342

343343
"""
344-
return self._get("ping", version=self.PRIVATE_API_VERSION)
344+
return self._get("ping")
345345

346346
def get_server_time(self) -> Dict:
347347
"""Test connectivity to the Rest API and get the current server time.
@@ -359,14 +359,14 @@ def get_server_time(self) -> Dict:
359359
:raises: BinanceRequestException, BinanceAPIException
360360

361361
"""
362-
return self._get("time", version=self.PRIVATE_API_VERSION)
362+
return self._get("time")
363363

364364
# Market Data Endpoints
365365

366366
def get_all_tickers(self) -> List[Dict[str, str]]:
367367
"""Latest price for all symbols.
368368

369-
https://binance-docs.github.io/apidocs/spot/en/#symbol-price-ticker
369+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#symbol-price-ticker
370370

371371
:returns: List of market tickers
372372

@@ -386,15 +386,15 @@ def get_all_tickers(self) -> List[Dict[str, str]]:
386386
:raises: BinanceRequestException, BinanceAPIException
387387

388388
"""
389-
response = self._get("ticker/price", version=self.PRIVATE_API_VERSION)
389+
response = self._get("ticker/price")
390390
if isinstance(response, list) and all(isinstance(item, dict) for item in response):
391391
return response
392392
raise TypeError("Expected a list of dictionaries")
393393

394394
def get_orderbook_tickers(self, **params) -> Dict:
395395
"""Best price/qty on the order book for all symbols.
396396

397-
https://binance-docs.github.io/apidocs/spot/en/#symbol-order-book-ticker
397+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#symbol-order-book-ticker
398398

399399
:param symbol: optional
400400
:type symbol: str
@@ -431,13 +431,13 @@ def get_orderbook_tickers(self, **params) -> Dict:
431431
elif "symbols" in params:
432432
data["symbols"] = params["symbols"]
433433
return self._get(
434-
"ticker/bookTicker", data=data, version=self.PRIVATE_API_VERSION
434+
"ticker/bookTicker", data=data
435435
)
436436

437437
def get_order_book(self, **params) -> Dict:
438438
"""Get the Order Book for the market
439439

440-
https://binance-docs.github.io/apidocs/spot/en/#order-book
440+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#order-book
441441

442442
:param symbol: required
443443
:type symbol: str
@@ -469,12 +469,12 @@ def get_order_book(self, **params) -> Dict:
469469
:raises: BinanceRequestException, BinanceAPIException
470470

471471
"""
472-
return self._get("depth", data=params, version=self.PRIVATE_API_VERSION)
472+
return self._get("depth", data=params)
473473

474474
def get_recent_trades(self, **params) -> Dict:
475475
"""Get recent trades (up to last 500).
476476

477-
https://binance-docs.github.io/apidocs/spot/en/#recent-trades-list
477+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#recent-trades-list
478478

479479
:param symbol: required
480480
:type symbol: str
@@ -504,7 +504,7 @@ def get_recent_trades(self, **params) -> Dict:
504504
def get_historical_trades(self, **params) -> Dict:
505505
"""Get older trades.
506506

507-
https://binance-docs.github.io/apidocs/spot/en/#old-trade-lookup
507+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#old-trade-lookup
508508

509509
:param symbol: required
510510
:type symbol: str
@@ -532,14 +532,14 @@ def get_historical_trades(self, **params) -> Dict:
532532

533533
"""
534534
return self._get(
535-
"historicalTrades", data=params, version=self.PRIVATE_API_VERSION
535+
"historicalTrades", data=params
536536
)
537537

538538
def get_aggregate_trades(self, **params) -> Dict:
539539
"""Get compressed, aggregate trades. Trades that fill at the time,
540540
from the same order, with the same price will have the quantity aggregated.
541-
542-
https://binance-docs.github.io/apidocs/spot/en/#compressed-aggregate-trades-list
541+
542+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints
543543

544544
:param symbol: required
545545
:type symbol: str
@@ -572,7 +572,7 @@ def get_aggregate_trades(self, **params) -> Dict:
572572
:raises: BinanceRequestException, BinanceAPIException
573573

574574
"""
575-
return self._get("aggTrades", data=params, version=self.PRIVATE_API_VERSION)
575+
return self._get("aggTrades", data=params)
576576

577577
def aggregate_trade_iter(self, symbol: str, start_str=None, last_id=None):
578578
"""Iterate over aggregate trade data from (start_time or last_id) to
@@ -697,12 +697,12 @@ def get_ui_klines(self, **params) -> Dict:
697697
:raises: BinanceRequestException, BinanceAPIException
698698

699699
"""
700-
return self._get("uiKlines", data=params, version=self.PRIVATE_API_VERSION)
700+
return self._get("uiKlines", data=params)
701701

702702
def get_klines(self, **params) -> Dict:
703703
"""Kline/candlestick bars for a symbol. Klines are uniquely identified by their open time.
704704

705-
https://binance-docs.github.io/apidocs/spot/en/#kline-candlestick-data
705+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#klinecandlestick-data
706706

707707
:param symbol: required
708708
:type symbol: str
@@ -739,7 +739,7 @@ def get_klines(self, **params) -> Dict:
739739
:raises: BinanceRequestException, BinanceAPIException
740740

741741
"""
742-
return self._get("klines", data=params, version=self.PRIVATE_API_VERSION)
742+
return self._get("klines", data=params)
743743

744744
def _klines(
745745
self, klines_type: HistoricalKlinesType = HistoricalKlinesType.SPOT, **params
@@ -1058,8 +1058,8 @@ def _historical_klines_generator(
10581058

10591059
def get_avg_price(self, **params):
10601060
"""Current average price for a symbol.
1061-
1062-
https://binance-docs.github.io/apidocs/spot/en/#current-average-price
1061+
1062+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#current-average-price
10631063

10641064
:param symbol:
10651065
:type symbol: str
@@ -1073,12 +1073,12 @@ def get_avg_price(self, **params):
10731073
"price": "9.35751834"
10741074
}
10751075
"""
1076-
return self._get("avgPrice", data=params, version=self.PRIVATE_API_VERSION)
1076+
return self._get("avgPrice", data=params)
10771077

10781078
def get_ticker(self, **params):
10791079
"""24 hour price change statistics.
10801080

1081-
https://binance-docs.github.io/apidocs/spot/en/#24hr-ticker-price-change-statistics
1081+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#24hr-ticker-price-change-statistics
10821082

10831083
:param symbol:
10841084
:type symbol: str
@@ -1134,7 +1134,7 @@ def get_ticker(self, **params):
11341134
:raises: BinanceRequestException, BinanceAPIException
11351135

11361136
"""
1137-
return self._get("ticker/24hr", data=params, version=self.PRIVATE_API_VERSION)
1137+
return self._get("ticker/24hr", data=params)
11381138

11391139
def get_symbol_ticker(self, **params):
11401140
"""Latest price for a symbol or symbols.
@@ -1171,12 +1171,12 @@ def get_symbol_ticker(self, **params):
11711171
:raises: BinanceRequestException, BinanceAPIException
11721172

11731173
"""
1174-
return self._get("ticker/price", data=params, version=self.PRIVATE_API_VERSION)
1174+
return self._get("ticker/price", data=params)
11751175

11761176
def get_symbol_ticker_window(self, **params):
11771177
"""Latest price for a symbol or symbols.
11781178

1179-
https://binance-docs.github.io/apidocs/spot/en/#rolling-window-price-change-statistics
1179+
https://developers.binance.com/docs/binance-spot-api-docs/rest-api/market-data-endpoints#rolling-window-price-change-statistics
11801180

11811181
:param symbol:
11821182
:type symbol: str
@@ -1208,7 +1208,7 @@ def get_symbol_ticker_window(self, **params):
12081208
:raises: BinanceRequestException, BinanceAPIException
12091209

12101210
"""
1211-
return self._get("ticker", data=params, version=self.PRIVATE_API_VERSION)
1211+
return self._get("ticker", data=params)
12121212

12131213
def get_orderbook_ticker(self, **params):
12141214
"""Latest price for a symbol or symbols.
@@ -1255,7 +1255,7 @@ def get_orderbook_ticker(self, **params):
12551255

12561256
"""
12571257
return self._get(
1258-
"ticker/bookTicker", data=params, version=self.PRIVATE_API_VERSION
1258+
"ticker/bookTicker", data=params
12591259
)
12601260

12611261
# Account Endpoints
@@ -3129,7 +3129,7 @@ def stream_get_listen_key(self):
31293129

31303130
"""
31313131
res = self._post(
3132-
"userDataStream", False, data={}, version=self.PRIVATE_API_VERSION
3132+
"userDataStream", False, data={}
31333133
)
31343134
return res["listenKey"]
31353135

@@ -3152,7 +3152,7 @@ def stream_keepalive(self, listenKey):
31523152
"""
31533153
params = {"listenKey": listenKey}
31543154
return self._put(
3155-
"userDataStream", False, data=params, version=self.PRIVATE_API_VERSION
3155+
"userDataStream", False, data=params
31563156
)
31573157

31583158
def stream_close(self, listenKey):

tests/conftest.py

Lines changed: 35 additions & 0 deletions

0 commit comments

Comments
 (0)