iframe-proxy

romainbrenguier · 2026-09-09T10:46:33Z

Summary

Move all 76 ruling expectation JSON files from its/ruling/src/test/resources/expected/ to its/ruling/src/test/resources/expected/web/project/
Update WebRulingTest.java to reference the new path
Normalize ruling expectation file locations so that it is consistent across all analyzers

Test plan

Verify ruling integration tests pass with the new file layout

🤖 Generated with Claude Code

Move ruling expectation files from expected/ to expected/web/project/ to follow the consistent expected/<language>/<project-key>/<rule-id>.json convention used across analyzers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

hashicorp-vault-sonar-prod · 2026-09-09T10:46:46Z

gitar-bot · 2026-09-09T10:48:20Z

      .setProperty("sonar.html.file.suffixes", "xhtml,html,php,erb")
      .setProperty("sonar.jsp.file.suffixes", "jspf,jsp")
-      .setProperty("sonar.lits.dump.old", FileLocation.of("src/test/resources/expected").getFile().getAbsolutePath())
+      .setProperty("sonar.lits.dump.old", FileLocation.of("src/test/resources/expected/web/project").getFile().getAbsolutePath())


⚠️ Bug: CI ruling auto-update still copies into old flat expected/ dir

The ruling auto-update step copies its/ruling/target/actual/* (a flat set of Web-*.json files produced by sonar.lits.dump.new) into its/ruling/src/test/resources/expected/, which was the correct target only while the expectations lived flat in that directory. After this PR the test reads expectations from expected/web/project, so on a ruling failure the workflow will commit 76 stale duplicate JSON files at the old root path and never update the files the test actually compares against — the auto-update becomes a no-op that pollutes the PR and the ruling test keeps failing. Point the copy at the new directory (the git add its/ruling/src/test/resources/expected/ line still covers the subdirectory).

Copy the LITS dump into the new expected/web/project directory:

cp -r its/ruling/target/actual/* its/ruling/src/test/resources/expected/web/project/

Apply fix

_{Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎}

gitar-bot · 2026-09-09T10:48:22Z

CI failed: The CI build failed because the generated ruling report comment exceeded the GitHub GraphQL API comment length limit of 65,536 characters.

Overview

1 log analyzed showing a failure during the GitHub comment creation step due to payload size limits being exceeded.

Failures

GitHub Comment Body Too Long (confidence: high)

Type: other
Affected jobs: 102435619958
Related to change: yes
Root cause: The generated PR comment containing the ruling report and diffs exceeded the maximum length of 65536 characters allowed by the GitHub GraphQL API.
Suggested fix: Truncate or summarize the ruling report comment contents in the workflow script to ensure it remains below the character limit.

Summary

Change-related failures: 1 failure due to excessive ruling report comment size
Infrastructure/flaky failures: 0
Recommended action: Update the workflow script that generates the ruling report comment to truncate or summarize long output before posting it to the PR.

Code Review ⚠️ Changes requested 0 resolved / 1 findings

Unifies ruling expectation file locations by moving 76 JSON files from its/ruling/src/test/resources/expected/ to its/ruling/src/test/resources/expected/web/project/. The CI ruling auto-update workflow still copies into the old flat expected/ directory, so on test failures it will commit stale duplicates and never update the files the test actually compares against — update the copy target in WebRulingTest.java:91 to point to the new directory.

⚠️

Bug: CI ruling auto-update still copies into old flat expected/ dir

📄 its/ruling/src/test/java/org/sonar/web/it/WebRulingTest.java:91

The ruling auto-update step copies its/ruling/target/actual/* (a flat set of Web-*.json files produced by sonar.lits.dump.new) into its/ruling/src/test/resources/expected/, which was the correct target only while the expectations lived flat in that directory. After this PR the test reads expectations from expected/web/project, so on a ruling failure the workflow will commit 76 stale duplicate JSON files at the old root path and never update the files the test actually compares against — the auto-update becomes a no-op that pollutes the PR and the ruling test keeps failing. Point the copy at the new directory (the git add its/ruling/src/test/resources/expected/ line still covers the subdirectory).

Copy the LITS dump into the new expected/web/project directory

cp -r its/ruling/target/actual/* its/ruling/src/test/resources/expected/web/project/

🤖 Prompt for agents

Code Review: Unifies ruling expectation file locations by moving 76 JSON files from `its/ruling/src/test/resources/expected/` to `its/ruling/src/test/resources/expected/web/project/`. The CI ruling auto-update workflow still copies into the old flat `expected/` directory, so on test failures it will commit stale duplicates and never update the files the test actually compares against — update the copy target in `WebRulingTest.java:91` to point to the new directory.

1. ⚠️ Bug: CI ruling auto-update still copies into old flat expected/ dir
   Files: its/ruling/src/test/java/org/sonar/web/it/WebRulingTest.java:91

   The ruling auto-update step copies `its/ruling/target/actual/*` (a flat set of `Web-*.json` files produced by `sonar.lits.dump.new`) into `its/ruling/src/test/resources/expected/`, which was the correct target only while the expectations lived flat in that directory. After this PR the test reads expectations from `expected/web/project`, so on a ruling failure the workflow will commit 76 stale duplicate JSON files at the old root path and never update the files the test actually compares against — the auto-update becomes a no-op that pollutes the PR and the ruling test keeps failing. Point the copy at the new directory (the `git add its/ruling/src/test/resources/expected/` line still covers the subdirectory).

   Fix (Copy the LITS dump into the new expected/web/project directory):
   cp -r its/ruling/target/actual/* its/ruling/src/test/resources/expected/web/project/

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`	`Unblock`
`gitar auto-apply:on`	`gitar display:verbose`	`gitar unblock`

_{Was this helpful? React with 👍 / 👎 | Gitar}

sonarqube-next · 2026-09-09T10:49:34Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

datadog-sonarsource · 2026-09-09T11:07:26Z

RC-350 Normalize ruling expectation file locations

5518094

Move ruling expectation files from expected/ to expected/web/project/ to follow the consistent expected/<language>/<project-key>/<rule-id>.json convention used across analyzers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

romainbrenguier requested a review from a team September 9, 2026 10:46

gitar-bot Bot reviewed Sep 9, 2026

View reviewed changes

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

RC-350 Unify ruling expectation file locations. - #827

RC-350 Unify ruling expectation file locations.#827
romainbrenguier wants to merge 1 commit into
masterfrom
romain/normalize-ruling-expectations

romainbrenguier commented Sep 9, 2026

Uh oh!

hashicorp-vault-sonar-prod Bot commented Sep 9, 2026 •

edited by atlassian Bot

Loading

Uh oh!

gitar-bot Bot Sep 9, 2026

Uh oh!

gitar-bot Bot commented Sep 9, 2026 •

edited

Loading

Overview

Failures

GitHub Comment Body Too Long (confidence: high)

Summary

Uh oh!

sonarqube-next Bot commented Sep 9, 2026

Uh oh!

datadog-sonarsource Bot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

romainbrenguier commented Sep 9, 2026

Summary

Test plan

Uh oh!

hashicorp-vault-sonar-prod Bot commented Sep 9, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitar-bot Bot Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Failures

GitHub Comment Body Too Long (confidence: high)

Summary

Uh oh!

sonarqube-next Bot commented Sep 9, 2026

Quality Gate passed

Uh oh!

datadog-sonarsource Bot commented Sep 9, 2026

⚠️ Warnings

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hashicorp-vault-sonar-prod Bot commented Sep 9, 2026 •

edited by atlassian Bot

Loading

gitar-bot Bot commented Sep 9, 2026 •

edited

Loading