Fix ShellCheck Errors in GitHub Actions Workflows · Issue #7653 · RustPython/RustPython · GitHub
Skip to content

Fix ShellCheck Errors in GitHub Actions Workflows #7653

@fanninpm

Description

@fanninpm

Summary

Currently, ShellCheck is reporting 5 findings in our GitHub Actions workflows.

Details

  • .github/workflows/lib-deps-check.yaml
    • Line 74 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally
    • Line 81 (info): Double quote to prevent globbing and word splitting
  • .github/workflows/update-doc-db.yml
    • Line 92 (info): Expressions don't expand in single quotes, use double quotes for that (this is by design; please insert # shellcheck: disable=SC2016 on a new line above this one)
    • Line 92 (style): Consider using { cmd1; cmd2; } >> file instead of individual redirects
  • .github/workflows/upgrade-pylib.lock.yml
    • Line 511 (style): Consider using { cmd1; cmd2; } >> file instead of individual redirects (in fact, the whole script block can be rewritten with this in mind)

cc @ShaharNaveh in #7639 (comment)

Metadata

Metadata

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions