Fix some parts of cron-ci workflow (#6724) · RustPython/RustPython@6cb763a · GitHub
Skip to content

Commit 6cb763a

Browse files
morealclaudeyouknowonefanninpm
authored
Fix some parts of cron-ci workflow (#6724)
* Use shared PYTHON_VERSION in cron-ci benchmark job * Correct extra-tests/jsontests.py script When the `extra_tests/jsontests.py` script was added, it was presumably during the time when Python versions 3.5 to 3.8 were in use. At that time, `test.libregrtest.runtest` was a valid path, but from CPython version 3.11 onwards, the path changed to `test.libregrtest.findtests`. * Use ssl-rustls feature instead of ssl in cron-ci workflow Replace the ssl feature with ssl-rustls in both the CARGO_ARGS environment variable and the cargo-llvm-cov test command to fix the cron-ci workflow. Since 1a783fc, it is disallowed to use ssl manually. * Replace inspect.getargspec with inspect.getfullargspec in custom_text_test_runner inspect.getargspec() was removed in Python 3.11, causing jsontests.py to fail with "TypeError: 'NoneType' object is not iterable" when running on RustPython (which targets Python 3.13). The get_function_args() function was silently catching the AttributeError and returning None, which then caused the error in store_class_fields() when trying to iterate over None. > https://docs.python.org/3/whatsnew/3.11.html > The getargspec() function, deprecated since Python 3.0; use > inspect.signature() or inspect.getfullargspec() instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Exclude rustpython-venvlauncher in cron-ci workflow Since rustpython-venvlauncher is Windows-only, it disables the project in the cron-ci workflow. * Apply suggestion from @fanninpm Co-authored-by: fanninpm <luxverdans@sbcglobal.net> * Trigger cron-ci workflow in pull_request --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com> Co-authored-by: fanninpm <luxverdans@sbcglobal.net>
1 parent 49e6931 commit 6cb763a

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

.github/workflows/cron-ci.yaml

Lines changed: 10 additions & 3 deletions

extra_tests/custom_text_test_runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def __call__(self, data_list, totals=None):
112112

113113
def get_function_args(func_ref):
114114
try:
115-
return [p for p in inspect.getargspec(func_ref).args if p != "self"]
115+
return [p for p in inspect.getfullargspec(func_ref).args if p != "self"]
116116
except:
117117
return None
118118

extra_tests/jsontests.py

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)