[FIX] Prevent UserAction.addStream without Subscription (#23705) · RocketChat/Rocket.Chat@d232e81 · GitHub
Skip to content

Commit d232e81

Browse files
tiagoevanpggazzo
andauthored
[FIX] Prevent UserAction.addStream without Subscription (#23705)
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
1 parent 7ed6846 commit d232e81

4 files changed

Lines changed: 22 additions & 9 deletions

File tree

‎app/ui/client/lib/UserAction.ts‎

Lines changed: 0 additions & 6 deletions

‎client/lib/RoomManager.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export const RoomManager = new (class RoomManager extends Emitter<{
132132
}
133133
})();
134134

135-
const subscribeVistedRooms: Subscription<IRoom['_id'][]> = {
135+
const subscribeVisitedRooms: Subscription<IRoom['_id'][]> = {
136136
getCurrentValue: () => RoomManager.visitedRooms(),
137137
subscribe(callback) {
138138
return RoomManager.on('changed', callback);
@@ -166,7 +166,7 @@ export const useHandleRoom = <T extends IRoom>(rid: IRoom['_id']): AsyncState<T>
166166
return state;
167167
};
168168

169-
export const useVisitedRooms = (): IRoom['_id'][] => useSubscription(subscribeVistedRooms);
169+
export const useVisitedRooms = (): IRoom['_id'][] => useSubscription(subscribeVisitedRooms);
170170

171171
export const useOpenedRoom = (): IRoom['_id'] | undefined => useSubscription(subscribeOpenedRoom);
172172

‎client/views/room/contexts/RoomContext.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { IRoom, IOmnichannelRoom, isOmnichannelRoom } from '../../../../definiti
55
export type RoomContextValue = {
66
rid: IRoom['_id'];
77
room: IRoom;
8+
subscribed: boolean;
89
};
910

1011
export const RoomContext = createContext<RoomContextValue | null>(null);

‎client/views/room/providers/RoomProvider.tsx‎

Lines changed: 19 additions & 1 deletion

0 commit comments

Comments
 (0)