chore(apps): remove the Deno runtime (#41201) · RocketChat/Rocket.Chat@679eb97 · GitHub
Skip to content

Commit 679eb97

Browse files
d-gubertclaude
d-gubert
and
claude
authored
chore(apps): remove the Deno runtime (#41201)
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent eec02bb commit 679eb97

40 files changed

Lines changed: 38 additions & 856 deletions

‎.devcontainer/Dockerfile‎

Lines changed: 0 additions & 10 deletions

‎.github/actions/build-docker/action.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ inputs:
1414
DOCKER_PASS:
1515
required: false
1616
description: 'DockerHub password (required for FIPS builds to pull private base image)'
17-
deno-version:
18-
required: true
19-
description: 'Deno version'
2017
arch:
2118
required: false
2219
description: 'Architecture'
@@ -114,7 +111,6 @@ runs:
114111
- name: Build Docker images
115112
shell: bash
116113
env:
117-
DENO_VERSION: ${{ inputs.deno-version }}
118114
INPUT_ARCH: ${{ inputs.arch }}
119115
INPUT_SERVICE: ${{ inputs.service }}
120116
INPUT_PUBLISH_IMAGE: ${{ inputs.publish-image }}

‎.github/actions/meteor-build/action.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ inputs:
1515
NPM_TOKEN:
1616
required: false
1717
description: 'NPM token'
18-
deno-version:
19-
required: true
20-
description: 'Deno version'
2118
source-hash:
2219
required: true
2320
description: 'RC cache id (e.g. packages-build-cache-key + meteor apps/meteor archive hash from CI)'
@@ -53,7 +50,6 @@ runs:
5350
if: steps.cache-build.outputs.cache-hit != 'true'
5451
with:
5552
node-version: ${{ inputs.node-version }}
56-
deno-version: ${{ inputs.deno-version }}
5753
cache-modules: true
5854
install: true
5955
type: 'production'

‎.github/actions/setup-node/action.yml‎

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ inputs:
1515
required: false
1616
description: 'development or production'
1717
default: 'development'
18-
deno-version:
19-
required: false
20-
description: 'Deno version. If not provided, read from .tool-versions'
2118
NPM_TOKEN:
2219
required: false
2320
description: 'NPM token'
@@ -30,9 +27,6 @@ outputs:
3027
node-version:
3128
description: 'Node version'
3229
value: ${{ steps.node-version.outputs.node-version }}
33-
cache-deno-hit:
34-
description: 'Exact key hit for Deno cache'
35-
value: ${{ steps.cache-deno.outputs.cache-hit }}
3630

3731
runs:
3832
using: composite
@@ -48,36 +42,13 @@ runs:
4842
echo "NODE_VERSION: ${NODE_VERSION}"
4943
echo "NODE_VERSION=${NODE_VERSION}" >> $GITHUB_ENV
5044
51-
DENO_VERSION="${{ inputs.deno-version }}"
52-
if [ -z "$DENO_VERSION" ]; then
53-
DENO_VERSION=$(awk '$1=="deno"{ print $2 }' .tool-versions)
54-
fi
55-
echo "DENO_VERSION: ${DENO_VERSION}"
56-
echo "DENO_VERSION=${DENO_VERSION}" >> $GITHUB_ENV
57-
58-
# Turbo local cache: use rharkor/caching-for-turbo in workflows — not stored here to avoid huge redundant keys.
59-
- name: Cache Deno (apps)
60-
if: inputs.cache-modules
61-
id: cache-deno
62-
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
63-
with:
64-
path: packages/apps/.deno-cache
65-
key: deno-${{ runner.os }}-${{ runner.arch }}-v${{ env.DENO_VERSION }}-${{ hashFiles('packages/apps/deno-runtime/deno.lock') }}
66-
restore-keys: |
67-
deno-${{ runner.os }}-${{ runner.arch }}-v${{ env.DENO_VERSION }}-
68-
6945
- name: Use Node.js ${{ env.NODE_VERSION }}
7046
id: node-version
7147
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
7248
with:
7349
node-version: ${{ env.NODE_VERSION }}
7450
cache: ${{ inputs.cache-modules && 'yarn' || '' }}
7551

76-
- name: Use Deno ${{ env.DENO_VERSION }}
77-
uses: denoland/setup-deno@667a34cdef165d8d2b2e98dde39547c9daac7282 # v2.0.4
78-
with:
79-
deno-version: ${{ env.DENO_VERSION }}
80-
8152
- name: Cache mongodb-memory-server binary
8253
if: inputs.cache-modules
8354
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5

‎.github/workflows/ci-code-check.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
node-version:
77
required: true
88
type: string
9-
deno-version:
10-
required: true
11-
type: string
129

1310
env:
1411
TOOL_NODE_FLAGS: ${{ vars.TOOL_NODE_FLAGS }}
@@ -40,7 +37,6 @@ jobs:
4037
uses: ./.github/actions/setup-node
4138
with:
4239
node-version: ${{ inputs.node-version }}
43-
deno-version: ${{ inputs.deno-version }}
4440
cache-modules: true
4541
install: true
4642
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

‎.github/workflows/ci-test-e2e.yml‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
node-version:
77
required: true
88
type: string
9-
deno-version:
10-
required: true
11-
type: string
129
lowercase-repo:
1310
required: true
1411
type: string
@@ -129,7 +126,6 @@ jobs:
129126
uses: ./.github/actions/setup-node
130127
with:
131128
node-version: ${{ inputs.node-version }}
132-
deno-version: ${{ inputs.deno-version }}
133129
cache-modules: true
134130
install: true
135131
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
@@ -207,7 +203,6 @@ jobs:
207203
TRANSPORTER: ${{ inputs.transporter }}
208204
COMPOSE_PROFILES: ${{ inputs.type == 'api' && 'api' || '' }}
209205
TEST_MODE: ${{ startsWith(inputs.type, 'api') && 'api' || 'true' }}
210-
APPS_ENGINE_RUNTIME_BACKEND: ${{ inputs.type == 'api-apps-deno' && 'deno' || '' }}
211206
FIPS_OVERRIDE: ${{ inputs.fips && '-f docker-compose-ci.fips.yml' || '' }}
212207
run: |
213208
read -r -a fips_override <<< "$FIPS_OVERRIDE"
@@ -246,23 +241,6 @@ jobs:
246241
ls -la "$COVERAGE_DIR"
247242
exit "${s:-0}"
248243
249-
# This step should be temporary, only here until we remove the deno-runtime
250-
- name: E2E Test API (apps + deno-runtime)
251-
if: (inputs.type == 'api-apps-deno' && inputs.release == 'ee')
252-
working-directory: ./apps/meteor
253-
env:
254-
WEBHOOK_TEST_URL: 'http://httpbin'
255-
IS_EE: 'true'
256-
run: |
257-
set -o xtrace
258-
259-
npm run testapi:apps || s=$?
260-
261-
docker compose -f ../../docker-compose-ci.yml stop
262-
263-
ls -la "$COVERAGE_DIR"
264-
exit "${s:-0}"
265-
266244
- name: E2E Test API (Livechat)
267245
if: inputs.type == 'api-livechat'
268246
working-directory: ./apps/meteor

‎.github/workflows/ci-test-storybook.yml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
node-version:
77
required: true
88
type: string
9-
deno-version:
10-
required: true
11-
type: string
129

1310
secrets:
1411
CODECOV_TOKEN:
@@ -36,7 +33,6 @@ jobs:
3633
uses: ./.github/actions/setup-node
3734
with:
3835
node-version: ${{ inputs.node-version }}
39-
deno-version: ${{ inputs.deno-version }}
4036
cache-modules: true
4137
install: true
4238
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

‎.github/workflows/ci-test-unit.yml‎

Lines changed: 0 additions & 4 deletions

0 commit comments

Comments
 (0)