clean strings (#54)

SandrineP · web-flow · commit 3cd3904ad310 · 2025-11-03T15:43:06.000Z
diff --git a/src/subcommand/checkout_subcommand.cpp b/src/subcommand/checkout_subcommand.cpp
@@ -59,7 +59,7 @@ void checkout_subcommand::run()
 annotated_commit_wrapper checkout_subcommand::create_local_branch
 (
     repository_wrapper& repo,
-    const std::string& target_name,
+    const std::string_view target_name,
     bool force
 )
 {
@@ -71,7 +71,7 @@ void checkout_subcommand::checkout_tree
 (
     const repository_wrapper& repo,
     const annotated_commit_wrapper& target_annotated_commit,
-    const std::string& target_name,
+    const std::string_view target_name,
     const git_checkout_options& options
 )
 {
@@ -83,7 +83,7 @@ void checkout_subcommand::update_head
 (
     repository_wrapper& repo,
     const annotated_commit_wrapper& target_annotated_commit,
-    const std::string& target_name
+    const std::string_view target_name
 )
 {
     std::string_view annotated_ref = target_annotated_commit.reference_name();
diff --git a/src/subcommand/checkout_subcommand.hpp b/src/subcommand/checkout_subcommand.hpp
@@ -20,23 +20,23 @@ class checkout_subcommand
     annotated_commit_wrapper create_local_branch
     (
         repository_wrapper& repo,
-        const std::string& target_name,
+        const std::string_view target_name,
         bool force
     );
 
     void checkout_tree
     (
         const repository_wrapper& repo,
         const annotated_commit_wrapper& target_annotated_commit,
-        const std::string& target_name,
+        const std::string_view target_name,
         const git_checkout_options& options
     );
 
     void update_head
     (
         repository_wrapper& repo,
         const annotated_commit_wrapper& target_annotated_commit,
-        const std::string& target_name
+        const std::string_view target_name
     );
 
     std::string m_branch_name = {};
diff --git a/src/utils/git_exception.cpp b/src/utils/git_exception.cpp
@@ -11,7 +11,7 @@ void throw_if_error(int exit_code)
 }
 
 
-git_exception::git_exception(const std::string& message, int error_code)
+git_exception::git_exception(const std::string_view message, int error_code)
     : m_message(message), m_error_code(error_code)
 {}
 
diff --git a/src/utils/git_exception.hpp b/src/utils/git_exception.hpp
@@ -8,13 +8,15 @@ void throw_if_error(int exit_code);
 class git_exception : public std::exception
 {
 public:
-    git_exception(const std::string& message, int error_code);
+
+    git_exception(const std::string_view message, int error_code);
 
     int error_code() const;
 
     const char* what() const noexcept override;
 
 private:
+
     std::string m_message;
     int m_error_code;
 };

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ void checkout_subcommand::run()`
`59`	`59`	`annotated_commit_wrapper checkout_subcommand::create_local_branch`
`60`	`60`	`(`
`61`	`61`	`repository_wrapper& repo,`
`62`		`- const std::string& target_name,`
	`62`	`+ const std::string_view target_name,`
`63`	`63`	`bool force`
`64`	`64`	`)`
`65`	`65`	`{`
`@@ -71,7 +71,7 @@ void checkout_subcommand::checkout_tree`
`71`	`71`	`(`
`72`	`72`	`const repository_wrapper& repo,`
`73`	`73`	`const annotated_commit_wrapper& target_annotated_commit,`
`74`		`- const std::string& target_name,`
	`74`	`+ const std::string_view target_name,`
`75`	`75`	`const git_checkout_options& options`
`76`	`76`	`)`
`77`	`77`	`{`
`@@ -83,7 +83,7 @@ void checkout_subcommand::update_head`
`83`	`83`	`(`
`84`	`84`	`repository_wrapper& repo,`
`85`	`85`	`const annotated_commit_wrapper& target_annotated_commit,`
`86`		`- const std::string& target_name`
	`86`	`+ const std::string_view target_name`
`87`	`87`	`)`
`88`	`88`	`{`
`89`	`89`	`std::string_view annotated_ref = target_annotated_commit.reference_name();`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ void throw_if_error(int exit_code)`
`11`	`11`	`}`
`12`	`12`
`13`	`13`
`14`		`-git_exception::git_exception(const std::string& message, int error_code)`
	`14`	`+git_exception::git_exception(const std::string_view message, int error_code)`
`15`	`15`	`: m_message(message), m_error_code(error_code)`
`16`	`16`	`{}`
`17`	`17`