In #11777, the readonly modifier was added to internal static members which raised an issue of our naming convention.
According to StyleCopAnalyzers on CodeFactor, "readonly variables that are not declared private must start with an upper-case letter" otherwise there are violations of the rule SA1304NonPrivateReadonlyFieldsMustBeginWithUpperCaseLetter
Our naming conventions state static fields should start with s_, however the existing code overwhelmingly uses PascalCase for internal static readonly members.
In my view conventions should be descriptive rather than prescriptive, so we should consider making changes to the written naming convention.
In #11777, the readonly modifier was added to internal static members which raised an issue of our naming convention.
According to StyleCopAnalyzers on CodeFactor, "readonly variables that are not declared private must start with an upper-case letter" otherwise there are violations of the rule SA1304NonPrivateReadonlyFieldsMustBeginWithUpperCaseLetter
Our naming conventions state static fields should start with
s_, however the existing code overwhelmingly uses PascalCase forinternal static readonlymembers.In my view conventions should be descriptive rather than prescriptive, so we should consider making changes to the written naming convention.