Activity

1. Jakub Kuczys (Jackenmen)

   added

   Issue-EnhancementIt's a feature request.It's a feature request.

   on Jun 3, 2023
2. ghost added

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Jun 3, 2023
3. StevenBucher98 commented on Jun 4, 2023

   

   Steven Bucher (StevenBucher98)

   on Jun 4, 2023

   Collaborator

   More actions

   Thanks for the issue Jakub Kuczys (@Jackenmen)! You change change the AcceptSuggestion function to the End key to accept the suggestion. I do not know the exact key name of the End key but if you run [System.Console]::ReadKey(), press the end key and use that "Key" property to fill in this commend Set-PSReadLineKeyHandler -Chord '<END KEY PROPERTY>' -Function MenuComplete. I am restricted to a laptop currently so don't have that key to test myself 😄 Let me know if that works for you!
4. Steven Bucher (StevenBucher98)

   added

   Needs-Author Feedback

   and removed

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Jun 4, 2023
5. Jackenmen commented on Jun 4, 2023

   

   Jakub Kuczys (Jackenmen)

   on Jun 4, 2023

   Author

   More actions

   I was asking for a change in the default behavior of the End key such that:

   • it moves the cursor to the end of the current editing line, if it isn't already there
   • it accepts the suggestion, otherwise (i.e. when the cursor is at the end of the current editing line)

   This would make it act more like the RightArrow key works:

   • it moves the cursor one character to the right, if it isn't at the end of the current editing line
   • it accepts the suggestion, otherwise (i.e. when the cursor is at the end of the current editing line)

   Right now, I use this custom key handler to do this:

   Set-PSReadLineKeyHandler -Key "End" `
           -BriefDescription ForwardCharAndAcceptNextSuggestionWord `
           -LongDescription "Move the cursor to the end of the current editing line or accept the suggestion if it's already there" `
           -ScriptBlock {
       param($key, $arg)
   
       $line = $null
       $cursor = $null
       [Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState([ref]$line, [ref]$cursor)
       if ($cursor -lt $line.Length) {
           [Microsoft.PowerShell.PSConsoleReadLine]::EndOfLine($key, $arg)
       } else {
           [Microsoft.PowerShell.PSConsoleReadLine]::AcceptSuggestion($key, $arg)
       }
   }

   but as I described in the issue, I think that this would be a sensible default to have which is why I'm requesting it. Personally, I feel like it's a weird inconsistency considering that both the right arrow and the End key are used for cursor movement.
6. ghost added

   Needs-Attention 👋

   on Jun 4, 2023
7. ghost removed

   Needs-Author Feedback

   on Jun 4, 2023
8. Jackenmen commented on Jun 4, 2023

   

   Jakub Kuczys (Jackenmen)

   on Jun 4, 2023

   Author

   More actions

   The relevant functions:
   

   PSReadLine/PSReadLine/Movement.cs

   Lines 17 to 34 in 9e7b1fe

   	/// <summary>
   	/// If the input has multiple lines, move to the end of the current line,
   	/// or if already at the end of the line, move to the end of the input.
   	/// If the input has a single line, move to the end of the input.
   	/// </summary>
   	public static void EndOfLine(ConsoleKeyInfo? key = null, object arg = null)
   	{
   	int i = _singleton._current;
   	for (; i < _singleton._buffer.Length; i++)
   	{
   	if (_singleton._buffer[i] == '\n')
   	{
   	break;
   	}
   	}
   	_singleton.MoveCursor((i == _singleton._current) ? _singleton._buffer.Length : i);
   	}

   
   

   PSReadLine/PSReadLine/Movement.cs

   Lines 49 to 66 in 9e7b1fe

   	/// <summary>
   	/// Move the cursor one character to the right. This may move the cursor to the next
   	/// line of multi-line input.
   	/// </summary>
   	public static void ForwardChar(ConsoleKeyInfo? key = null, object arg = null)
   	{
   	if (TryGetArgAsInt(arg, out var numericArg, 1))
   	{
   	if (_singleton._current == _singleton._buffer.Length && numericArg > 0)
   	{
   	AcceptSuggestion(key, arg);
   	}
   	else
   	{
   	SetCursorPosition(_singleton._current + numericArg);
   	}
   	}
   	}
9. Steven Bucher (StevenBucher98)

   added

   Area-PredictorsLabel for issues related to predictorsLabel for issues related to predictors

   on Aug 14, 2023
10. microsoft-github-policy-service

    added

    Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

    on Aug 14, 2023
11. Steven Bucher (StevenBucher98)

    removed

    Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

    Needs-Attention 👋

    on Aug 21, 2023
12. Steven Bucher (StevenBucher98)

    added this to the Future milestone on Aug 21, 2023