Activity

1. David Hatch (dhatch48)

   added

   Issue-EnhancementIt's a feature request.It's a feature request.

   on Jul 26, 2020
2. ghost added

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Jul 26, 2020
3. daxian-dbw commented on Jul 26, 2020

   

   Dongbo Wang (daxian-dbw)

   on Jul 26, 2020

   Member

   More actions

   David Hatch (@dhatch48) You can do that by Set-PSReadLineKeyHandler -Key 'j,k' -ViMode Insert -Function ViCommandMode
4. Dongbo Wang (daxian-dbw)

   added

   Resolution-AnsweredQuestion is answeredQuestion is answered

   and removed

   Issue-EnhancementIt's a feature request.It's a feature request.

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Jul 26, 2020
5. SeeminglyScience commented on Jul 26, 2020

   

   Patrick Meinecke (SeeminglyScience)

   on Jul 26, 2020

   Collaborator

   More actions

   Dongbo Wang (@daxian-dbw) I can't get that to work right. I mean it works, but you can't type j anymore.
6. daxian-dbw commented on Jul 26, 2020

   

   Dongbo Wang (daxian-dbw)

   on Jul 26, 2020

   Member

   More actions

   Yeah, j will be bound after that and won't be treated as a literal character. I think that's just an example. Key sequences should be chosen to not interfere with the regular input, like Set-PSReadlineKeyHandler -Chord 'Ctrl+d,Ctrl+c' -Function CaptureScreen
7. SeeminglyScience commented on Jul 26, 2020

   

   Patrick Meinecke (SeeminglyScience)

   on Jul 26, 2020

   Collaborator

   More actions

   Yeah, j will be bound after that and won't be treated as a literal character. I think that's just an example.

   Nah jk or jj (what I use) to exit insert mode is super common. Usually it works like this:

   1. You press j
   2. j is written to the buffer
   3. A timer starts
   4. If you press the next key in the sequence before the timer is up, the j is removed from the buffer and the command fires
   5. If the key you press next isn't in the sequence, or the timer is up then it's treated like a literal

   👍React with 👍7Reacted by David Hatch, wesdgray, Nimmidev, Andy Jordan, noamper, Ted Middleton and Les Matheson
8. dhatch48 commented on Jul 27, 2020

   

   David Hatch (dhatch48)

   on Jul 27, 2020

   Author

   More actions

   Yeah, j will be bound after that and won't be treated as a literal character. I think that's just an example. Key sequences should be chosen to not interfere with the regular input, like Set-PSReadlineKeyHandler -Chord 'Ctrl+d,Ctrl+c' -Function CaptureScreen

   I think Patrick Meinecke (@SeeminglyScience) explained it nicely. Many vim users have bindings of jj or jk to exit insert mode because it is so common to switch modes and this way it keeps your fingers on the home row vs. reaching for Esc key every time.

   Anyway, I suppose a sequence timer/timeout is needed to make this work.
9. Dongbo Wang (daxian-dbw)

   added

   VI-Mode

   and removed

   Resolution-AnsweredQuestion is answeredQuestion is answered

   on Jul 27, 2020
10. Dongbo Wang (daxian-dbw)

    changed the title [-]Allow Set-PSReadLineKeyHandler to bind a key sequence[/-] [+]Allow a key sequence binding like `j,k` to not prevent user from insert `j`[/+] on Jul 27, 2020
11. daxian-dbw commented on Jul 27, 2020

    

    Dongbo Wang (daxian-dbw)

    on Jul 27, 2020

    Member

    More actions

    I see. Thanks for clarifying it.
    I have changed the title and PR description to reflect what is really asked for.

    👍React with 👍5Reacted by David Hatch, Patrick Meinecke, wesdgray, Nimmidev and Ted Middleton
12. Dongbo Wang (daxian-dbw)

    added

    Issue-EnhancementIt's a feature request.It's a feature request.

    and removed

    VI-Mode

    on Jul 27, 2020
13. Dongbo Wang (daxian-dbw)

    added this to the Future milestone on Jul 27, 2020
14. Dongbo Wang (daxian-dbw)

    added

    Not-Planned

    on Oct 7, 2020
15. Dongbo Wang (daxian-dbw)

    assigned

    Jason Helmick (theJasonHelmick)

    on Nov 30, 2020
16. Jason Helmick (theJasonHelmick)

    removed their assignment

    on Jan 5, 2021
17. Drllap commented on Jan 23, 2022

    

    Páll Andrés Pálsson (Drllap)

    on Jan 23, 2022

    More actions

    This is what I added to my profile to make jk go to comand mode:

    $j_timer = New-Object System.Diagnostics.Stopwatch
    
    Set-PSReadLineKeyHandler -Key j -ViMode Insert -ScriptBlock {
        [Microsoft.PowerShell.PSConsoleReadLine]::Insert("j")
        $j_timer.Restart()
    }
    
    Set-PSReadLineKeyHandler -Key k -ViMode Insert -ScriptBlock {
        if (!$j_timer.IsRunning -or $j_timer.ElapsedMilliseconds -gt 1000) {
            [Microsoft.PowerShell.PSConsoleReadLine]::Insert("k")
        } else {
            [Microsoft.PowerShell.PSConsoleReadLine]::ViCommandMode()
            $line = $null
            $cursor = $null
            [Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState([ref]$line, [ref]$cursor)
            [Microsoft.PowerShell.PSConsoleReadLine]::Delete($cursor, 1)
            [Microsoft.PowerShell.PSConsoleReadLine]::SetCursorPosition($cursor-1)
        }
    }
    

    👍React with 👍6Reacted by SARDONYX, Lazaro Alberto Herrera, flexw, Jim, Andy Jordan and Luke Brown
18. slacksystem commented on Jan 6, 2023

    

    Slack System (slacksystem)

    on Jan 6, 2023

    More actions

    This is what I added to my profile to make jk go to comand mode:

    $j_timer = New-Object System.Diagnostics.Stopwatch
    
    Set-PSReadLineKeyHandler -Key j -ViMode Insert -ScriptBlock {
        [Microsoft.PowerShell.PSConsoleReadLine]::Insert("j")
        $j_timer.Restart()
    }
    
    Set-PSReadLineKeyHandler -Key k -ViMode Insert -ScriptBlock {
        if (!$j_timer.IsRunning -or $j_timer.ElapsedMilliseconds -gt 1000) {
            [Microsoft.PowerShell.PSConsoleReadLine]::Insert("k")
        } else {
            [Microsoft.PowerShell.PSConsoleReadLine]::ViCommandMode()
            $line = $null
            $cursor = $null
            [Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState([ref]$line, [ref]$cursor)
            [Microsoft.PowerShell.PSConsoleReadLine]::Delete($cursor, 1)
            [Microsoft.PowerShell.PSConsoleReadLine]::SetCursorPosition($cursor-1)
        }
    }
    

    Since this is under not-planned, it seems, I'm trying to figure out how to change this so it's jj instead of jk but I can't figure it out. Do you have any ideas how I could do that?
19. Drllap commented on Feb 25, 2023

    

    Páll Andrés Pálsson (Drllap)

    on Feb 25, 2023

    More actions

    Slack System (@slacksystem) try this:

    $j_timer = New-Object System.Diagnostics.Stopwatch
    Set-PSReadLineKeyHandler -Key j -ViMode Insert -ScriptBlock {
        if (!$j_timer.IsRunning -or $j_timer.ElapsedMilliseconds -gt 1000) {
            [Microsoft.PowerShell.PSConsoleReadLine]::Insert("j")
            $j_timer.Restart()
            return
        }
    
        [Microsoft.PowerShell.PSConsoleReadLine]::Insert("j")
        [Microsoft.PowerShell.PSConsoleReadLine]::ViCommandMode()
        $line = $null
        $cursor = $null
        [Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState([ref]$line, [ref]$cursor)
        [Microsoft.PowerShell.PSConsoleReadLine]::Delete($cursor-1, 2)
        [Microsoft.PowerShell.PSConsoleReadLine]::SetCursorPosition($cursor-2)
    }
    
    
20. Dongbo Wang (daxian-dbw)

    added

    Area-KeyHandlersLabel for issues related to key handlersLabel for issues related to key handlers

    on Dec 11, 2023