fix: do not retry transactions on any error by laurenceisla · Pull Request #4222 · PostgREST/postgrest · GitHub
Skip to content

fix: do not retry transactions on any error#4222

Draft
laurenceisla wants to merge 2 commits intoPostgREST:mainfrom
laurenceisla:fix/transaction-no-retry
Draft

fix: do not retry transactions on any error#4222
laurenceisla wants to merge 2 commits intoPostgREST:mainfrom
laurenceisla:fix/transaction-no-retry

Conversation

@laurenceisla
Copy link
Copy Markdown
Member

@laurenceisla laurenceisla commented Jul 23, 2025

WIP

Should close #3673.

@laurenceisla laurenceisla force-pushed the fix/transaction-no-retry branch 3 times, most recently from 1afa5fb to 665f55c Compare August 13, 2025 01:48
@steve-chavez
Copy link
Copy Markdown
Member

@wolfgangwalther
Copy link
Copy Markdown
Member

We should not vendor it, for two reasons:

  • First of all, we haven't even done our own work, yet. We can't update to hasql 1.8 or 1.9 before the static build is sorted out - and it currently doesn't look like there will be progress soon. The upstream Nixpkgs PR that Build static executable for linux aarch64 (w/ TH) #4193 depends on is likely not going to get merged - and currently Nixpkgs is not even able to build pkgsStatic.libpq anmyore. This only worked by accident. Thus, upgrading to GHC 9.6 and then hasql is quite far out of reach for us right now.
  • 3 weeks without reaction is not "no reaction", imho. Especially when there has been no additional ping in the PR, yet, etc.

@laurenceisla laurenceisla force-pushed the fix/transaction-no-retry branch 3 times, most recently from ff133bf to 23426d2 Compare August 14, 2025 19:28
@laurenceisla
Copy link
Copy Markdown
Member Author

laurenceisla commented Aug 14, 2025

Michael and I arrived at mostly the same things independently. Took some
of his, some of mine.

Co-authored-by: Michal Kleczek <michal@kleczek.org>
@laurenceisla laurenceisla force-pushed the fix/transaction-no-retry branch from 23426d2 to 4fd5a69 Compare April 23, 2026 01:12
@laurenceisla laurenceisla force-pushed the fix/transaction-no-retry branch from 4fd5a69 to 592802c Compare April 23, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Surprising infinite retrying of SQL statement on a replica causes replication lag

3 participants