feat: add Huawei and email_reply_to_address parameters to Notification#73
Conversation
4019c00 to
d27eb61
Compare
d27eb61 to
8a5dfca
Compare
8a5dfca to
d9d4ca8
Compare
d9d4ca8 to
d122df9
Compare
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
In general, fix this by explicitly setting minimal permissions for jobs that use the default GITHUB_TOKEN, instead of relying on repo defaults. For jobs that only need to read the repository (or not use the token at all), set contents: read at the job or workflow level; only grant write scopes where strictly required.
For this workflow, the release job already has a permissions block. The publish job (lines 49–120) does not, so we should add an explicit permissions block under publish:. The steps in publish only require cloning the code and uploading artifacts; both can work with a read‑only contents permission. Therefore, the best fix is to add:
permissions:
contents: readright below the existing runs-on: ubuntu-latest line in the publish job. This preserves all existing behavior while ensuring the GITHUB_TOKEN used in this job is limited to read‑only access to repository contents. No additional imports, methods, or definitions are needed, since this is purely a YAML configuration change.
| @@ -51,6 +51,8 @@ | ||
| needs: release | ||
| if: needs.release.outputs.new_release_published == 'true' | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| env: | ||
| MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }} | ||
| MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }} |
email_reply_to_address parameters to Notification
7bb3637 to
e01cee1
Compare
email_reply_to_address parameters to Notification## [5.3.0](v5.2.0...v5.3.0) (2026-03-24) ### Features * add Huawei and email_reply_to_address parameters to Notification ([#73](#73)) ([62dc9fc](62dc9fc)) [skip ci]
## 1.0.0 (2026-03-27) ### Features * add Huawei and email_reply_to_address parameters to Notification ([OneSignal#73](https://github.com/URIKIRI/onesignal-java-api/issues/73)) ([62dc9fc](62dc9fc)) * add v2.1.0 package updates ([396600b](396600b)) * add v2.2.0 package updates ([b220ea8](b220ea8)) * add v2.2.0 package updates ([46ba07a](46ba07a)) * add v5.0.0-beta1 package updates ([c1fbcf6](c1fbcf6)) * add v5.1.0-beta1 package updates ([c819297](c819297)) * add v5.2.0-beta1 package updates ([c493f79](c493f79)) * add v5.2.0-beta1 package updates ([cce80aa](cce80aa)) * add v5.2.0-beta1 package updates ([bf1380d](bf1380d)) * add v5.2.0-beta1 package updates ([de99c8a](de99c8a)) * add v5.2.1-beta1 package updates ([c8fbe0a](c8fbe0a)) * add v5.3.0-beta1 package updates ([670ae2c](670ae2c)) * add v5.3.0-beta1 package updates ([697b2f8](697b2f8)) * add v5.3.0-beta1 package updates ([90f6f83](90f6f83)) * add v5.3.0-beta1 package updates ([a6d6c75](a6d6c75)) * add v5.3.0-beta1 package updates ([1dceaaf](1dceaaf)) * add v5.3.0-beta1 package updates ([a8d3d46](a8d3d46)) * add v5.3.0-beta1 package updates ([abdb323](abdb323)) [skip ci]

Features
Adds the following
Notificationparameters:huawei_badge_classhuawei_badge_add_numhuawei_badge_set_numhuawei_categoryhuawei_bi_tagemail_reply_to_address