{{ message }}
Repository navigation
fix #1569 - improve monitor_regex - #1595
Merged
Merged
Conversation
|
This pull request fixes 1 alert when merging 8c5506d into 7e77de8 - view on LGTM.com fixed alerts:
|
gkorland
approved these changes
Apr 8, 2021
OnlineCop
reviewed
Apr 28, 2021
OnlineCop
left a comment
OnlineCop
left a comment
There was a problem hiding this comment.
The original, ending in ( ".+?")+$, would fail to match:
1234567890.0 [1 2] "test"
(There are two spaces between the closing square bracket and the double quote.)
The new, ending in .*"$, will match that string (or any other string, so long as the last character on the line is a double quote).
Should this text match, or fail to match?
Contributor
Author
This was referenced Sep 8, 2024
florian-schunk
pushed a commit
to florian-schunk/node-redis
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Guy Korland <gkorland@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.