Initialisation exceptions swallowed · Issue #330 · microsoft/vscode-languageserver-node · GitHub
Skip to content

Initialisation exceptions swallowed #330

Closed

Description

I just had trouble diagnosing a LanguageClient which did not resolve or reject the onReady promise, and I could not find an exception noted anywhere.

Similar to this issue - there was an exception in initializeFeatures https://github.com/Microsoft/vscode-languageserver-node/blob/020764e3eacc76138ffbf63f09489adbfb9e1be8/client/src/client.ts#L2614

Is this as simple as moving then(..., ...) to then(...).catch(...) ?

Activity

  1. dbaeumer commented on Apr 3, 2018

    @dbaeumer
    Member

    Nicholas Wolverson (@nwolverson) thanks. Since VS Code's Thenable interface doesn't offer a catch I changed it to then(...).then(undefined, ....).

  2. locked and limited conversation to collaborators on May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions