Add NO_FPS_LIMIT instead of magic numbers · MicroPythonNexus/circuitpython@923a5b2 · GitHub
Skip to content

Commit 923a5b2

Browse files
tannewttannewt
committed
Add NO_FPS_LIMIT instead of magic numbers
1 parent 807edd4 commit 923a5b2

6 files changed

Lines changed: 8 additions & 6 deletions

File tree

‎shared-bindings/displayio/Display.c‎

Lines changed: 2 additions & 2 deletions

‎shared-bindings/displayio/Display.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
extern const mp_obj_type_t displayio_display_type;
3636

3737
#define NO_BRIGHTNESS_COMMAND 0x100
38+
#define NO_FPS_LIMIT 0xffffffff
3839

3940
void common_hal_displayio_display_construct(displayio_display_obj_t *self,
4041
mp_obj_t bus, uint16_t width, uint16_t height,

‎shared-bindings/framebufferio/FramebufferDisplay.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,15 @@ STATIC mp_obj_t framebufferio_framebufferdisplay_obj_refresh(size_t n_args, cons
136136
mp_arg_parse_all(n_args - 1, pos_args + 1, kw_args, MP_ARRAY_SIZE(allowed_args), allowed_args, args);
137137

138138
framebufferio_framebufferdisplay_obj_t *self = native_display(pos_args[0]);
139-
uint32_t maximum_ms_per_real_frame = 0xffffffff;
139+
uint32_t maximum_ms_per_real_frame = NO_FPS_LIMIT;
140140
mp_int_t minimum_frames_per_second = args[ARG_minimum_frames_per_second].u_int;
141141
if (minimum_frames_per_second > 0) {
142142
maximum_ms_per_real_frame = 1000 / minimum_frames_per_second;
143143
}
144144

145145
uint32_t target_ms_per_frame;
146146
if (args[ARG_target_frames_per_second].u_obj == mp_const_none) {
147-
target_ms_per_frame = 0xffffffff;
147+
target_ms_per_frame = NO_FPS_LIMIT;
148148
} else {
149149
target_ms_per_frame = 1000 / mp_obj_get_int(args[ARG_target_frames_per_second].u_obj);
150150
}

‎shared-bindings/framebufferio/FramebufferDisplay.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
extern const mp_obj_type_t framebufferio_framebufferdisplay_type;
3737

3838
#define NO_BRIGHTNESS_COMMAND 0x100
39+
#define NO_FPS_LIMIT 0xffffffff
3940

4041
void common_hal_framebufferio_framebufferdisplay_construct(framebufferio_framebufferdisplay_obj_t *self,
4142
mp_obj_t framebuffer,

‎shared-module/displayio/Display.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ uint16_t common_hal_displayio_display_get_rotation(displayio_display_obj_t *self
354354

355355

356356
bool common_hal_displayio_display_refresh(displayio_display_obj_t *self, uint32_t target_ms_per_frame, uint32_t maximum_ms_per_real_frame) {
357-
if (!self->auto_refresh && !self->first_manual_refresh && (target_ms_per_frame != 0xffffffff)) {
357+
if (!self->auto_refresh && !self->first_manual_refresh && (target_ms_per_frame != NO_FPS_LIMIT)) {
358358
uint64_t current_time = supervisor_ticks_ms64();
359359
uint32_t current_ms_since_real_refresh = current_time - self->core.last_refresh;
360360
// Test to see if the real frame time is below our minimum.

‎shared-module/framebufferio/FramebufferDisplay.c‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)