chore: clean up leftovers from the assets package removal (#31) · MeAkib/angular-devtools@71bde44 · GitHub
Skip to content

Commit 71bde44

Browse files
authored
chore: clean up leftovers from the assets package removal (pangular-inspector#31)
* chore: clean up leftovers from the assets package removal - CI checks only extension/ui for stale build output - CONTRIBUTING and AGENTS no longer mention ng-devtools-assets - remove unused NgRx types - remove the root valibot dependency, which only the package uses * chore: keep the NgRx types for upcoming store work
1 parent d62f789 commit 71bde44

5 files changed

Lines changed: 7 additions & 11 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 3 additions & 3 deletions

‎AGENTS.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,5 @@ You are an expert in TypeScript, Angular, and scalable web application developme
6464
- **Devtools SPA (hot reload):** `pnpm devtools:dev` → http://localhost:5173 (requires the SSR server running for RPC data)
6565
- **Demo app (SPA, no SSR):** `pnpm start` → http://localhost:4200 (runs `ng serve` with SSR and hot reload; devtools popup + RPC work without a separate server)
6666
- The devtools popup appears on the demo app page; click it to open the inspector panel
67-
- Changes to `app/src/` (devtools SPA) are only visible via `pnpm devtools:dev`; the SSR server serves the npm-published assets
68-
- To publish updated SPA assets: update versions in `packages/ng-devtools/package.json` and `packages/ng-devtools-assets/package.json`, then run `pnpm devtools:publish` (builds and publishes both `ng-devtools` and `ng-devtools-assets` to npm)
67+
- Changes to `app/src/` (devtools SPA) are visible live via `pnpm devtools:dev`; the SSR server serves the SPA built into `packages/ng-devtools/dist/public` (or the npm-published copy when it has not been built), so run `pnpm devtools:build-pkg` to refresh it
68+
- To publish: update the version in `packages/ng-devtools/package.json`, then run `pnpm devtools:publish` (the package build bundles the SPA)

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ pnpm install
2020
```
2121
app/ # Devtools UI SPA (Angular + Vite)
2222
src/app.ts # Root component with tab navigation
23-
src/pages/ # Dashboard, Components, Routes, Signals, Injectors
23+
src/pages/ # Dashboard, Components, Routes, Signals, Injectors, Store, Forms
2424
vite.config.ts # Vite config with Analog Angular plugin
2525
packages/
2626
ng-devtools/ # Publishable npm package
@@ -86,6 +86,6 @@ pnpm format:check
8686
1. Fork and create a branch from `main`
8787
2. Make your changes
8888
3. Verify `pnpm devtools:build` succeeds
89-
4. If you changed `app/`, run `pnpm extension:build && pnpm devtools:build-pkg` and commit `extension/ui` and `packages/ng-devtools-assets/dist`. CI fails when they are stale
89+
4. If you changed `app/`, run `pnpm extension:build` and commit `extension/ui`. CI fails when it is stale
9090
5. Test with `pnpm devtools:dev`
9191
6. Open a PR against `main`

‎package.json‎

Lines changed: 0 additions & 1 deletion

‎pnpm-lock.yaml‎

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)