You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(cli): skipping GCP service-account creation still returns a fabricated account email #2007
gcpStepCreateServiceAccount builds the expected service-account email up front and returns it on every branch, including Skip and unknown input, so the wizard continues with an identity it never created or verified. Step 4 then prints a grant for that principal and Step 5 tries to mint a key for it, and the failure surfaces several steps later as an opaque IAM error. The sibling gcpStepCreateKey returns an empty string on skip so the caller can ask for an existing credentials file.
An operator answers s at Step 3 because they already use a differently named service account. The wizard reports "grants roles/compute.admin to cudly-service-account@.iam.gserviceaccount.com" for a principal that does not exist, then fails at key creation with an IAM error that does not mention the skipped step.
Return an empty string on skip and prompt for the existing service-account email, the way gcpStepCreateKey already returns "" on skip so the caller asks for an existing credentials file.
Found by the 2026-09-02 codebase audit, finding A10-020, reported by one reviewer and independently confirmed by a second. Full report: docs/audits/codebase-audit-2026-09-02.md.
Activity
cristim commentedon Oct 16, 2026
Claiming: working on this [claude-cli-impl]
fix(cli): prompt for an existing service account when GCP setup skips…